Uh oh!
There was an error while loading. Please reload this page.
Fix quota type to int - #34019
Merged
Merged
Conversation
Change the quota to int from float, since the quota is a number of bits and a bits can not be splitted. Fix#34010 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
PVince81, icewind1991 and skjnldsv
and removed request for
a teamSeptember 12, 2022 07:28
solracsf
commented
Sep 12, 2022
Member
Backport? |
CarlSchwan
commented
Sep 12, 2022
MemberAuthor
/backport to stable24 |
come-nc
approved these changes
Sep 12, 2022
1 task
Merged
PVince81
commented
Nov 22, 2022
Member
reverted on NC 24 and NC 25 as it broke quotas on 32-bit architecture: |
PVince81
commented
Nov 22, 2022
Member
we keep it on NC 26 / master where we deprecate 32-bit support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the quota to int from float, since the quota is a number of bits and a bits can not be splitted.
Fix#34010