Skip to content

Fix avatar icons in user list when using dark theme - #34022

Merged
PVince81 merged 1 commit into
masterfrom
fix/dark-avatar-user-list
Sep 12, 2022
Merged

Fix avatar icons in user list when using dark theme#34022
PVince81 merged 1 commit into
masterfrom
fix/dark-avatar-user-list

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwanCarlSchwan added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 12, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Sep 12, 2022
@CarlSchwanCarlSchwan self-assigned this Sep 12, 2022
Comment threadapps/settings/src/components/UserList.vue
@szaimenszaimen added ui-refresh-feedback 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Sep 12, 2022

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then but didn't test

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit c22d44b into masterSep 12, 2022
@PVince81
PVince81 deleted the fix/dark-avatar-user-list branch September 12, 2022 13:14
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
@AndyXheli

Copy link
Copy Markdown
Contributor

Hi @CarlSchwan Im not sure if i should creat a new ticker or we can reopen ticket #34006

Same results on NC 25 Beta 7

imageimage

@nursoda

nursoda commented Sep 19, 2022

Copy link
Copy Markdown

Same results on NC 25 Beta 7

@AndyXheli You DID Shift-Reload, right? Caching seems to do odd things with the new theming…

@AndyXheli

Copy link
Copy Markdown
Contributor

Hey @nursoda Yes I did! Cleared cache, tried different browsers same results not sure if it matters users are populating via LDAP

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Avatar New style looks weird

5 participants

@CarlSchwan@AndyXheli@nursoda@PVince81@szaimen