Skip to content

fix strange-looking button - #34030

Merged
szaimen merged 2 commits into
masterfrom
enh/33835/button
Sep 13, 2022
Merged

fix strange-looking button#34030
szaimen merged 2 commits into
masterfrom
enh/33835/button

Conversation

@szaimen

@szaimenszaimen commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

Close#33835

BeforeAfter
imageimage

Signed-off-by: szaimen szaimen@e.mail.de

@szaimenszaimen added this to the Nextcloud 25 milestone Sep 12, 2022
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/compile /

@szaimen
szaimen requested review from a team, CarlSchwan, PVince81, artonge and skjnldsv and removed request for a teamSeptember 12, 2022 13:29
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 12, 2022
@szaimen
szaimen marked this pull request as ready for review September 12, 2022 13:29
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@blizzz

Copy link
Copy Markdown
Member

i thought scss is dead, but then i may have misunderstood?

@szaimen

Copy link
Copy Markdown
ContributorAuthor

i thought scss is dead, but then i may have misunderstood?

the files app is not ported to vue yet so why should scss be dead?

@blizzz

Copy link
Copy Markdown
Member

i thought scss is dead, but then i may have misunderstood?

the files app is not ported to vue yet so why should scss be dead?

Excellent question.

@CarlSchwan

Copy link
Copy Markdown
Member

i thought scss is dead, but then i may have misunderstood?

Scss compiled by the php server is dead, scss compiled by node is not

@szaimen

Copy link
Copy Markdown
ContributorAuthor

CI faolure unrelated

@szaimen
szaimen merged commit 9be1d5b into masterSep 13, 2022
@szaimen
szaimen deleted the enh/33835/button branch September 13, 2022 08:15
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New folder input fields look strange

5 participants

@szaimen@blizzz@CarlSchwan@skjnldsv@nextcloud-command