Skip to content

Add api to load additional section in profile page - #34042

Merged
CarlSchwan merged 1 commit into
masterfrom
profile/section-plugin
Sep 14, 2022
Merged

Add api to load additional section in profile page#34042
CarlSchwan merged 1 commit into
masterfrom
profile/section-plugin

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Sep 12, 2022

Copy link
Copy Markdown
Member

image

@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Sep 12, 2022
@CarlSchwanCarlSchwan self-assigned this Sep 12, 2022
@CarlSchwan
CarlSchwan marked this pull request as draft September 12, 2022 20:59
Comment threadcore/Controller/ProfilePageController.php Fixed
Comment threadcore/Controller/ProfilePageController.php Fixed
Comment threadcore/Controller/ProfilePageController.php Fixed
Comment threadcore/Controller/ProfilePageController.php Fixed
@CarlSchwan
CarlSchwan marked this pull request as ready for review September 13, 2022 13:50
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Sep 13, 2022
@CarlSchwan
CarlSchwanforce-pushed the profile/section-plugin branch 2 times, most recently from 9c1bbe5 to f9c0127CompareSeptember 13, 2022 13:57

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see minor comments

Comment threadcore/src/profile.js Outdated
Comment threadcore/src/profile/ProfileSections.js
Comment threadcore/Controller/ProfilePageController.php
Comment threadcore/src/views/Profile.vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwan merged commit 7ea015f into masterSep 14, 2022
@CarlSchwan
CarlSchwan deleted the profile/section-plugin branch September 14, 2022 11:35
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlSchwan@PVince81@artonge@Pytal@github-advanced-security@come-nc