Uh oh!
There was an error while loading. Please reload this page.
Fix unresponsive legacy password confirmation dialog when another modal is open with new dialog in Vue - #34044
Merged
Merged
Conversation
Closed
ChristophWurst
approved these changes
Sep 13, 2022
CarlSchwan
approved these changes
Sep 13, 2022
PVince81
commented
Sep 13, 2022
Member
|
PVince81
commented
Sep 13, 2022
Member
I'll investigate the issue |
PVince81
commented
Sep 13, 2022
Member
very strange, compilation actually works and the dialog also works |
PVince81
commented
Sep 13, 2022
Member
possibly https://stackoverflow.com/q/67648680 I also didn't find any other place where we'd be importing css modules from a non-local module. |
Pytalforce-pushed
the
fix/password-confirmation
branch
from
September 13, 2022 18:38
70083a6 to
8e8ebfcComparePytal
commented
Sep 13, 2022
MemberAuthor
Analysis and upstream fix in nextcloud-libraries/nextcloud-password-confirmation#393 Pending next package release to resolve all errors |
…in Vue Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
fix/password-confirmation
branch
from
September 14, 2022 17:23
8e8ebfc to
26535e4Compare Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this the focus would remain on the previously opened modal and prevent confirmation of your password
Also improves accessibility
Steps