Skip to content

Fix unresponsive legacy password confirmation dialog when another modal is open with new dialog in Vue - #34044

Merged
Pytal merged 1 commit into
masterfrom
fix/password-confirmation
Sep 14, 2022
Merged

Fix unresponsive legacy password confirmation dialog when another modal is open with new dialog in Vue#34044
Pytal merged 1 commit into
masterfrom
fix/password-confirmation

Conversation

@Pytal

@PytalPytal commented Sep 13, 2022

Copy link
Copy Markdown
Member

Without this the focus would remain on the previously opened modal and prevent confirmation of your password

Also improves accessibility

Steps

  1. Open user management page
  2. Create a new user with the modal
  3. Confirm your password

The appendChild console error can be ignored and is fixed upstream in nextcloud-libraries/nextcloud-vue#3219

@PytalPytal added this to the Nextcloud 25 milestone Sep 13, 2022
@PytalPytal self-assigned this Sep 13, 2022
@PytalPytal mentioned this pull request Sep 13, 2022
@PytalPytal changed the title Fix unresponsive legacy password confirmation dialog when another modal is open with dialog in VueFix unresponsive legacy password confirmation dialog when another modal is open with new dialog in VueSep 13, 2022

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

Copy link
Copy Markdown
Member
error Unable to resolve path to module '@nextcloud/password-confirmation/style.css'

@PVince81

Copy link
Copy Markdown
Member

I'll investigate the issue

@PVince81

Copy link
Copy Markdown
Member

very strange, compilation actually works and the dialog also works
it's only eslint that doesn't seem to be able to load the password-confirmation lib

@PVince81

Copy link
Copy Markdown
Member

possibly https://stackoverflow.com/q/67648680

I also didn't find any other place where we'd be importing css modules from a non-local module.
Not sure if we should change it to require() now or something else.

@Pytal

Copy link
Copy Markdown
MemberAuthor

Analysis and upstream fix in nextcloud-libraries/nextcloud-password-confirmation#393

Pending next package release to resolve all errors

@PytalPytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 13, 2022
…in Vue
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the fix/password-confirmation branch from 8e8ebfc to 26535e4CompareSeptember 14, 2022 17:23
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 14, 2022
@Pytal
Pytal merged commit bd03c79 into masterSep 14, 2022
@Pytal
Pytal deleted the fix/password-confirmation branch September 14, 2022 19:54
@skjnldsvskjnldsv mentioned this pull request Sep 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilitybug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal@PVince81@ChristophWurst@CarlSchwan