Skip to content

merge last_activity and last_check updates - #34056

Closed
icewind1991 wants to merge 1 commit into
masterfrom
merge-token-updates
Closed

merge last_activity and last_check updates#34056
icewind1991 wants to merge 1 commit into
masterfrom
merge-token-updates

Conversation

@icewind1991

Copy link
Copy Markdown
Member

updateActivity has been updated to also write any other changed field.

the debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period.

This is pretty much a 2nd version of #1037, which was reverted(#29682) after the last_activity updating changed by #29357

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Sep 13, 2022
@icewind1991icewind1991 added this to the Nextcloud 25 milestone Sep 13, 2022
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, come-nc and skjnldsv and removed request for a teamSeptember 13, 2022 14:56
@icewind1991
icewind1991force-pushed the merge-token-updates branch 2 times, most recently from 7217c0c to 7d434e8CompareSeptember 13, 2022 17:14
@icewind1991

Copy link
Copy Markdown
MemberAuthor

I've done some basic testing to ensure that both last_activity and last_check get updated under normal use

This was referenced Sep 20, 2022
@blizzzblizzz modified the milestones: Nextcloud 25, Nextcloud 26Sep 22, 2022
@blizzzblizzz mentioned this pull request Feb 1, 2023
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
@blizzzblizzz mentioned this pull request Mar 7, 2023
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
@come-nc

Copy link
Copy Markdown
Contributor

I do not have enought understanding/knowledge to approve this, sorry

@come-nc
come-nc removed their request for review March 21, 2023 10:53
This was referenced May 3, 2023
This was referenced Nov 10, 2023
@blizzzblizzz mentioned this pull request Nov 20, 2023
5 tasks
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@susnux
susnux requested review from nfebe and removed request for CarlSchwanJune 21, 2024 09:00
the debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period.
Signed-off-by: Robin Appelman <robin@icewind.nl>

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my understanding, very clean!

@susnux

Copy link
Copy Markdown
Contributor

But the test needs to be adjusted @icewind1991

 There was 1 failure:
1) Test\User\SessionTest::testLoginLastCheckUpdate
Expectation failed for method name is "updateToken" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

@ChristophWurst

Copy link
Copy Markdown
Member

Wasn't this addressed with #45026?

This was referenced Jul 30, 2024
@AltahrimAltahrim mentioned this pull request Aug 5, 2024
@skjnldsvskjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
@susnux
susnux deleted the merge-token-updates branch April 23, 2025 11:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991@come-nc@susnux@ChristophWurst@blizzz@skjnldsv