Uh oh!
There was an error while loading. Please reload this page.
merge last_activity and last_check updates - #34056
Closed
icewind1991 wants to merge 1 commit into
Closed
Conversation
icewind1991
requested review from
a team, ArtificialOwl, come-nc and skjnldsv
and removed request for
a teamSeptember 13, 2022 14:56
icewind1991force-pushed
the
merge-token-updates
branch
2 times, most recently
from
September 13, 2022 17:14
7217c0c to
7d434e8Compareicewind1991
commented
Sep 13, 2022
MemberAuthor
I've done some basic testing to ensure that both |
icewind1991force-pushed
the
merge-token-updates
branch
from
September 14, 2022 12:11
7d434e8 to
f012969Compare Merged
ChristophWurst
approved these changes
Sep 16, 2022
Merged
Merged
Merged
come-nc
commented
Mar 21, 2023
Contributor
I do not have enought understanding/knowledge to approve this, sorry |
come-nc
removed their request for review
March 21, 2023 10:53
AndyScherzingerforce-pushed
the
merge-token-updates
branch
from
February 27, 2024 13:15
f012969 to
491f058Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
icewind1991force-pushed
the
merge-token-updates
branch
from
June 21, 2024 08:55
491f058 to
568c4b4Comparethe debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period. Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
merge-token-updates
branch
from
June 21, 2024 09:01
568c4b4 to
f6d18f8Comparesusnux
approved these changes
Jun 21, 2024
susnux
left a comment
Contributor
There was a problem hiding this comment.
Looks good from my understanding, very clean!
susnux
commented
Jun 21, 2024
Contributor
But the test needs to be adjusted @icewind1991 |
ChristophWurst
commented
Jul 17, 2024
Member
Wasn't this addressed with #45026? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateActivityhas been updated to also write any other changed field.the debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period.
This is pretty much a 2nd version of #1037, which was reverted(#29682) after the
last_activityupdating changed by #29357