Skip to content

Convert file_metadata.id from int(11) to bigint(20) - #34067

Merged
PVince81 merged 3 commits into
masterfrom
timm2k-patch-1
Sep 15, 2022
Merged

Convert file_metadata.id from int(11) to bigint(20)#34067
PVince81 merged 3 commits into
masterfrom
timm2k-patch-1

Conversation

@timm2k

Copy link
Copy Markdown
Contributor

file_metadata.id runs out of range for very large instances.

file_metadata.id needs to be bigint(20).
Signed-off-by: timm2k <timm2k@gmx.de>
Signed-off-by: timm2k <timm2k@gmx.de>
@CarlSchwanCarlSchwan added the 3. to review Waiting for reviews label Sep 14, 2022
@CarlSchwanCarlSchwan added this to the Nextcloud 25 milestone Sep 14, 2022
@artonge

Copy link
Copy Markdown
Collaborator

Backport ?

@CarlSchwan

Copy link
Copy Markdown
Member

/backport to stable24

@nickvergessen

Copy link
Copy Markdown
Member

/backport to stable24

@nickvergessen

Copy link
Copy Markdown
Member

Should also change the migration which creates the column, otherwise you do a new install and have a warning waiting for you

@timm2k

Copy link
Copy Markdown
ContributorAuthor

Should also change the migration which creates the column, otherwise you do a new install and have a warning waiting for you

is this done by chaning core/Migrations/Version24000Date20220404230027.php?

@@ -45,7 +45,7 @@
if (!$schema->hasTable('file_metadata')) {
$table = $schema->createTable('file_metadata');
- $table->addColumn('id', Types::INTEGER, [
+ $table->addColumn('id', Types::BIGINT, [
'notnull' => true,
]);
$table->addColumn('group_name', Types::STRING, [

Signed-off-by: timm2k <timm2k@gmx.de>
@nickvergessen

Copy link
Copy Markdown
Member

Yes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@timm2k@artonge@CarlSchwan@nickvergessen@PVince81