Add accessibility entry in user menu

[PVince81]

For #33736

Note: if the theming app is disabled the entry will remove itself.

[szaimen]

I think when in that section also the entry in the nav manager should be highlighted, no?
See

[nimishavijay]

Looks good, a suggestion: we use the A11y icon instead of the theming icon https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Aaccessibility_new%3A

[PVince81]

@szaimen I thought of this but don't think it's critical. It would also mean that whenever you manually click on that navigation, the entry on the top right would also need to be highlighted. Might need a hacky solution for this.

[szaimen]

@szaimen I thought of this but don't think it's critical. It would also mean that whenever you manually click on that navigation, the entry on the top right would also need to be highlighted. Might need a hacky solution for this.

look at https://github.com/nextcloud/server/pull/33756/files#diff-0fc396967e1f9523319e6bbfd0d6877a8a6e5db7a7896697404c19ea896f734dR137-R140. Maybe it helps figuring out a solution

[PVince81]

here we go:

@nimishavijay

@szaimen as per screenshot, the active item is now fixed, thanks a lot for the useful pointer

please re-review!

[szaimen]

lgtm now but acceptance-header failure is related!

[PVince81]

solved

[szaimen]

S3 failure unrelated

[nursoda]

I understand the wish to make this submenu easier accessible. However, I think it's inconsistent in terms of "now we have three links to the same side menu" – two main entry points (user, admin) and one sidemenu subentry on top of it. If theming and accessibility were a complete separate side menu, then I'd agree. This way, I don't. But that's not my decision.

BUT: Even the icons used are inconsistent. THAT should be decided upon which one to use consistently:

[jancborchardt]

@nursoda yes, understandable – however all of the requirements for having each of the entries quickly accessible are valid. Initially we only had "Settings", then it was cumbersome for admins to get to admin settings quickly, or not clear that this was also there. And "Appearance and accessibility" needs to be reachable quickly to help people in need of assistive technology.

Regarding the icon, yes for sure. @szaimen could you change the icon of "Appearance & accessibility" in the settings to the one we use in the menu (the "human")? Admin theming can keep its icon to distinguish.

[szaimen]

WIP: #34170