Skip to content

Automate CA certificate bundle update - #34107

Merged
nickvergessen merged 3 commits into
masterfrom
automate-cacert-update
Sep 18, 2022
Merged

Automate CA certificate bundle update#34107
nickvergessen merged 3 commits into
masterfrom
automate-cacert-update

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen mentioned this pull request Sep 16, 2022
@kesselb

Copy link
Copy Markdown
Contributor

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Interesting that we have this check and it never failed....

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

if [[ -n${DRONE_SOURCE_BRANCH}&&!${DRONE_SOURCE_BRANCH}=~ version(\/noid)?\/([0-9.]+) ]];then
echo"Skip CA bundle check"
exit 0
fi

uuuuuuuuuuuuuuff

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2022
@kesselb

Copy link
Copy Markdown
Contributor

Interesting that we have this check and it never failed....

It failed sometimes ;) However the check for a certain branch name was always unstable. The schedule based workflow is much better.

Comment thread.github/workflows/update-cacert-bundle.yml Outdated
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@@ -0,0 +1,42 @@
name: Update CA certificate bundle

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add your copyright here. I'll be fine if we could adopt spdx notation to make it shorter

# SPDX-FileCopyrightText: 2022 Your name <email>
# SPDX-License-Identifier: AGPL-3.0-or-later

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's "high" enough to have copyright

@nickvergessen
nickvergessen merged commit 061d621 into masterSep 18, 2022
@nickvergessen
nickvergessen deleted the automate-cacert-update branch September 18, 2022 08:24
@blizzzblizzz mentioned this pull request Sep 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishsecurity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@kesselb@ChristophWurst@skjnldsv@CarlSchwan