Uh oh!
There was an error while loading. Please reload this page.
return proper error code when reporting exception fails in remote.php - #34438
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team, ArtificialOwl, PVince81 and skjnldsv
and removed request for
a teamOctober 5, 2022 10:42
icewind1991
commented
Oct 5, 2022
MemberAuthor
/backport to stable25 |
icewind1991
commented
Oct 5, 2022
MemberAuthor
/backport to stable24 |
icewind1991
commented
Oct 5, 2022
MemberAuthor
/backport to stable23 |
skjnldsv
approved these changes
Oct 5, 2022
ChristophWurst
approved these changes
Oct 13, 2022
This was referenced Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the returned status will be
200which will be interpreted incorrectly by clientsFor easy testing, throw an exception in
ConnectionFactory::getConnectionto simulate a broken DB server