Skip to content

[stable24] Fix User profile picture when performing the search - #34440

Merged
skjnldsv merged 6 commits into
stable24from
backport/32635/stable24
Oct 27, 2022
Merged

[stable24] Fix User profile picture when performing the search#34440
skjnldsv merged 6 commits into
stable24from
backport/32635/stable24

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #32635

@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 24.0.6 milestone Oct 5, 2022
@blizzzblizzz mentioned this pull request Oct 6, 2022
@blizzzblizzz added the 3. to review Waiting for reviews label Oct 6, 2022
@AndyXheli

AndyXheli commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Hey @Pytal I noticed on NC 24.0.6 while have this patch manually and being on dark theme the picture look off but in white mode looks good. No issue on NC 25

Any suggestions.
imageimage

@Pytal

Pytal commented Oct 7, 2022

Copy link
Copy Markdown
Member

On NC25 the invert was removed in this commit 1dee36c#diff-dd69ed2809161cd760c9e20b8a388d8eb0564a2385cc8d0235b4b91e73c26d6e

I've pushed a fix

@AndyXheli

Copy link
Copy Markdown
Contributor

Thank you! :)

@Pytal
Pytal requested review from artonge and blizzzOctober 7, 2022 19:54
@AndyXheli

Copy link
Copy Markdown
Contributor

@blizzz can we also get this merge please?

@skjnldsvskjnldsv mentioned this pull request Oct 27, 2022
2 tasks

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

Copy link
Copy Markdown
Member

/rebase

Andy Xheliand others added 6 commits October 27, 2022 10:04
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Tested no issues.
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2022
@skjnldsv
skjnldsv merged commit 04ec0d7 into stable24Oct 27, 2022
@skjnldsv
skjnldsv deleted the backport/32635/stable24 branch October 27, 2022 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AndyXheli@Pytal@PVince81@blizzz@skjnldsv