Uh oh!
There was an error while loading. Please reload this page.
Fix case sensitivity of email when saving settings - #34629
Merged
Conversation
CarlSchwan
commented
Oct 17, 2022
MemberAuthor
/backport to stable25 |
CarlSchwan
commented
Oct 17, 2022
MemberAuthor
/backport to stable24 |
CarlSchwan
commented
Oct 17, 2022
MemberAuthor
/backport to stable23 |
PVince81
commented
Nov 4, 2022
Member
add a unit test for this ? |
Otherwise we detect a email change all the time and since email are immutable in ldap this prevent updating other fields. Related: #33813 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81force-pushed
the
fix/case-sensitivity-email-ldap
branch
from
December 16, 2022 16:47
ef97425 to
f9ea078ComparePVince81
commented
Dec 16, 2022
Member
rebased and added a unit test |
PVince81
enabled auto-merge
December 16, 2022 16:57
This was referenced Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we detect a email change all the time and since email are immutable in ldap this prevent updating other fields.
Related: #33813
Signed-off-by: Carl Schwan carl@carlschwan.eu