Skip to content

[stable25] on installation save channel to config.php if not stable - #34726

Merged
PVince81 merged 2 commits into
stable25from
backport/34136/stable25
Oct 27, 2022
Merged

[stable25] on installation save channel to config.php if not stable#34726
PVince81 merged 2 commits into
stable25from
backport/34136/stable25

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #34136

- the default channel to the NC server is what is provided in /version.php
unless it is overridden in config.php
- the default channel to the NC Updater however is 'stable'
- this resultant in inconsistent results and confusing admin experience
- therefore "stable" is considered default and other channels are being
written to config.php now upon installation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 25.0.1 milestone Oct 21, 2022
@skjnldsvskjnldsv mentioned this pull request Oct 27, 2022

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81PVince81 added the 3. to review Waiting for reviews label Oct 27, 2022

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@PVince81
PVince81 merged commit 883bda7 into stable25Oct 27, 2022
@PVince81
PVince81 deleted the backport/34136/stable25 branch October 27, 2022 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PVince81@szaimen@blizzz