Uh oh!
There was an error while loading. Please reload this page.
Fix size calculation on copying the skeleton files - #34834
Merged
Conversation
otherwise the filecache will have a wrong size for skeleton files Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
a team, CarlSchwan, come-nc and icewind1991
and removed request for
a teamOctober 27, 2022 06:49
come-nc
approved these changes
Nov 3, 2022
PVince81
commented
Nov 4, 2022
Member
backports needed ? |
juliusknorr
commented
Nov 4, 2022
MemberAuthor
Yes, would be good. |
juliusknorr
commented
Nov 4, 2022
MemberAuthor
/backport to stable25 |
juliusknorr
commented
Nov 4, 2022
MemberAuthor
/backport to stable24 |
juliusknorr
commented
Nov 4, 2022
MemberAuthor
/backport to stable23 |
The backport to stable24 failed. Please do this backport manually. |
The backport to stable25 failed. Please do this backport manually. |
The backport to stable23 failed. Please do this backport manually. |
This was referenced Nov 9, 2022
nickvergessen
commented
Nov 18, 2022
Member
Brings a strange regression on 24 + 23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use proper storage methods to copy the skeleton files as otherwise the size propagation for the newly added files (and the user quota usage) will be wrong after the first login with object storage.
For local storage this works fine as the files are getting scanned afterwards.