Uh oh!
There was an error while loading. Please reload this page.
Avoid a crash when a PHP extension has no version - #34937
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
commented
Nov 3, 2022
/backport to stable25 |
come-nc
commented
Nov 3, 2022
/backport to stable24 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
szaimen
commented
Nov 3, 2022
hm... Seems like psalm fails? Maybe suppress the psalm error? |
come-nc
commented
Nov 3, 2022
vimeo/psalm#8655 sent a fix upstream, let’s see if it gets merged quickly and we can just update, or if we have to suppress the error instead. |
szaimen
commented
Nov 4, 2022
I guess lets suppress the error message then? |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
szaimen
commented
Nov 7, 2022
/backport to stable23 |
szaimen
commented
Nov 7, 2022
/backport to stable24 |
The issue appears again under Nextcloud 27.1.3. When I visit the “Users” menu under a regular account, I've got the “An error occurred during the request. Unable to proceed” message, which does not show up under my admin account. This happens when I set “Group admim for” for a regular user. |
come-nc
commented
Nov 13, 2023
This has nothing to do with this pull request or the related issue, please open a new issue after checking if there is already one opened. |
The signature known to our psalm is somehow wrong here, getVersion can actually return null according to php documentation and issues opened by users.
Should fix#34716
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com