Uh oh!
There was an error while loading. Please reload this page.
Fix sidebar not automatically hidden in Files app - #35052
Merged
szaimen merged 1 commit intoNov 9, 2022
Conversation
danxuliu
requested review from
a team, Pytal, skjnldsv and szaimen
and removed request for
a teamNovember 9, 2022 12:53
danxuliu
commented
Nov 9, 2022
MemberAuthor
/backport to stable25 |
danxuliu
commented
Nov 9, 2022
MemberAuthor
/backport to stable24 |
danxuliu
commented
Nov 9, 2022
MemberAuthor
/backport to stable23 |
nickvergessen
commented
Nov 9, 2022
Member
3rdparty change should not be here? |
skjnldsv
approved these changes
Nov 9, 2022
nickvergessen
previously requested changes
Nov 9, 2022
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Blocking due to unintended 3rdparty bump
Although the Files app creates the legacy sidebar (details view) it is
then replaced with the newer Vue app sidebar. Due to this ".detailsView"
no longer finds an element and therefore nothing was hidden when
"hideAppSidebar($('.detailsView'))" was called (for example, when
changing to another section).
However, "OC.Apps.hideAppSidebar()" does not properly work either with
the Vue sidebar used in the Files app (once hidden the sidebar is not
shown again). For simplicity, and to avoid any possible side effect in
other apps from changing "OC.Apps.hideAppSidebar", now
"OC.Files.Sidebar.close()" is used instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>danxuliuforce-pushed
the
fix-sidebar-not-hidden-when-changing-section-in-files-app
branch
from
November 9, 2022 16:46
bb799d3 to
a8fea27Comparedanxuliu
commented
Nov 9, 2022
MemberAuthor
Ugh 🤦 Sorry, fixed now. |
Pytal
approved these changes
Nov 9, 2022
szaimen
deleted the
fix-sidebar-not-hidden-when-changing-section-in-files-app
branch
November 9, 2022 18:51
This was referenced Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#33848
This might be happening since #15719 (but I have not verified it)
Although the Files app creates the legacy sidebar (details view) it is then replaced with the newer Vue app sidebar. Due to this
.detailsViewno longer finds an element and therefore nothing was hidden whenhideAppSidebar($('.detailsView'))was called (for example, when changing to another section).However,
OC.Apps.hideAppSidebar()does not properly work either with the Vue sidebar used in the Files app (once hidden the sidebar is not shown again). For simplicity, and to avoid any possible side effect in other apps from changingOC.Apps.hideAppSidebar, nowOC.Files.Sidebar.close()is used instead.How to test
Result with this pull request
The sidebar is hidden
Result without this pull request
The sidebar is not hidden