Skip to content

[stable23] Fix top margin in empty versions list - #35073

Merged
szaimen merged 2 commits into
stable23from
backport/35063/stable23
Nov 11, 2022
Merged

[stable23] Fix top margin in empty versions list#35073
szaimen merged 2 commits into
stable23from
backport/35063/stable23

Conversation

@st3iny

@st3inyst3iny commented Nov 10, 2022

Copy link
Copy Markdown
Member

Manual backport of #35063

Tested locally via nc-easy-test.

Manual backport of #35063
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3inyst3iny added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Nov 10, 2022
@st3inyst3iny added this to the Nextcloud 23.0.12 milestone Nov 10, 2022
@st3iny
st3iny requested a review from a teamNovember 10, 2022 10:30
@st3inyst3iny self-assigned this Nov 10, 2022
@st3iny
st3iny requested review from PVince81, artonge and szaimen and removed request for a teamNovember 10, 2022 10:30
@st3inyst3iny changed the title Fix top margin in empty versions list[stable23] Fix top margin in empty versions listNov 10, 2022
@szaimen
szaimen requested a review from PytalNovember 10, 2022 17:13
@szaimen

Copy link
Copy Markdown
Contributor

/compile

@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 10, 2022
@szaimen

Copy link
Copy Markdown
Contributor
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
node:internal/crypto/hash:71
this[kHandle] = new _Hash(algorithm, xofLen);
^
Error: error:0308010C:digital envelope routines::unsupported
at new Hash (node:internal/crypto/hash:71:19)
at Object.createHash (node:crypto:133:10)
at module.exports (/home/runner/work/server/server/node_modules/webpack/lib/util/createHash.js:135:53)
at NormalModule._initBuildHash (/home/runner/work/server/server/node_modules/webpack/lib/NormalModule.js:417:16)
at handleParseError (/home/runner/work/server/server/node_modules/webpack/lib/NormalModule.js:471:10)
at /home/runner/work/server/server/node_modules/webpack/lib/NormalModule.js:503:5
at /home/runner/work/server/server/node_modules/webpack/lib/NormalModule.js:358:12
at /home/runner/work/server/server/node_modules/loader-runner/lib/LoaderRunner.js:373:3
at iterateNormalLoaders (/home/runner/work/server/server/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
at iterateNormalLoaders (/home/runner/work/server/server/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
at /home/runner/work/server/server/node_modules/loader-runner/lib/LoaderRunner.js:236:3
at context.callback (/home/runner/work/server/server/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
at /home/runner/work/server/server/node_modules/babel-loader/lib/index.js:59:71 {
opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
library: 'digital envelope routines',
reason: 'unsupported',
code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

@szaimen

Copy link
Copy Markdown
Contributor

Seems like node 18 does not work for stable23... @skjnldsv any idea how to downgrade the used node version?

@skjnldsv

skjnldsv commented Nov 11, 2022

Copy link
Copy Markdown
Member

Seems like node 18 does not work for stable23... @skjnldsv any idea how to downgrade the used node version?

Use nvm https://github.com/nvm-sh/nvm

Also we require node 16 for Nextcloud on master, not node 18.
https://github.com/nextcloud/github_helper/blob/d752b259a66855d3bbed60ef43b5b913f3207bb4/.github/workflows/dispatch-npm-engines.yml#L52-L53

@szaimen

Copy link
Copy Markdown
Contributor

Seems like node 18 does not work for stable23... @skjnldsv any idea how to downgrade the used node version?

Use nvm https://github.com/nvm-sh/nvm

Also we require node 16 for Nextcloud on master, not node 18. https://github.com/nextcloud/github_helper/blob/d752b259a66855d3bbed60ef43b5b913f3207bb4/.github/workflows/dispatch-npm-engines.yml#L52-L53

I meant how to downgrade Node on CI :)

Screenshot_20221111_085924_Brave

@skjnldsv

skjnldsv commented Nov 11, 2022

Copy link
Copy Markdown
Member

Edit the package.json and use ^ instead of >=

"engines": {
"node": "^14.0.0",
"npm": "^7.0.0"
},

EDIT: done

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@szaimen

Copy link
Copy Markdown
Contributor

Thanks! :)

@szaimen
szaimen merged commit 084dc48 into stable23Nov 11, 2022
@szaimen
szaimen deleted the backport/35063/stable23 branch November 11, 2022 09:25
@blizzzblizzz mentioned this pull request Nov 21, 2022
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@st3iny@szaimen@skjnldsv@Pytal