Skip to content

Mark more config values as sensitive - #35096

Merged
szaimen merged 1 commit into
masterfrom
bugfix/noid/mark-more-values-as-sensitive
Nov 14, 2022
Merged

Mark more config values as sensitive#35096
szaimen merged 1 commit into
masterfrom
bugfix/noid/mark-more-values-as-sensitive

Conversation

@nickvergessen

@nickvergessennickvergessen commented Nov 11, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Mark more config values as sensitive
663cf04
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Nov 11, 2022
@nickvergessennickvergessen added this to the Nextcloud 26 milestone Nov 11, 2022
@nickvergessennickvergessen self-assigned this Nov 11, 2022
@nickvergessen
nickvergessen requested review from come-nc and removed request for a teamNovember 11, 2022 08:03
@szaimen
szaimen merged commit 98543b1 into masterNov 14, 2022
@szaimen
szaimen deleted the bugfix/noid/mark-more-values-as-sensitive branch November 14, 2022 08:45
@blizzz

blizzz commented Nov 14, 2022

Copy link
Copy Markdown
Member

Should be done on app side via $context->registerSensitiveMethods, e.g. nextcloud/sharepoint#143

@nickvergessen

nickvergessen commented Nov 14, 2022

Copy link
Copy Markdown
MemberAuthor

Should be done on app side via

We can do that going forward, but we also need to backport this one 🙈

@nickvergessen

nickvergessen commented Nov 14, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@nickvergessen

nickvergessen commented Nov 14, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable24

@nickvergessen

nickvergessen commented Nov 14, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@nickvergessen

nickvergessen commented Nov 14, 2022

Copy link
Copy Markdown
MemberAuthor

Should be done on app side via $context->registerSensitiveMethods, e.g

Wait, that is about methods. Not about the system report / config list. While still good and mostlikely related it's a different thing.
Will queue a task to check if both are properly documented and then suggest a dev news update with it.

@blizzz

blizzz commented Nov 14, 2022

Copy link
Copy Markdown
Member

Should be done on app side via $context->registerSensitiveMethods, e.g

Wait, that is about methods. Not about the system report / config list. While still good and mostlikely related it's a different thing. Will queue a task to check if both are properly documented and then suggest a dev news update with it.

Good point, didn't realize it (need more coffee). Probably need to add support to register var names.

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 14, 2022

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 14, 2022

Copy link
Copy Markdown

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 14, 2022

Copy link
Copy Markdown

The backport to stable23 failed. Please do this backport manually.

@nickvergessen

nickvergessen commented Nov 15, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@nickvergessen

nickvergessen commented Nov 15, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable24

@nickvergessen

nickvergessen commented Nov 15, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 15, 2022

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 15, 2022

Copy link
Copy Markdown

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 15, 2022

Copy link
Copy Markdown

The backport to stable23 failed. Please do this backport manually.

This was referenced Nov 16, 2022
Merged
Merged
Merged
@nickvergessen

nickvergessen commented Nov 16, 2022

Copy link
Copy Markdown
MemberAuthor

Manual backports above

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimenszaimenszaimen approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl
@blizzzblizzzAwaiting requested review from blizzz

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@blizzz@szaimen@come-nc