Skip to content

Make sure to not pass null to DateTime::createFromFormat - #35157

Merged
come-nc merged 1 commit into
masterfrom
fix/avoid-passing-null-to-datetime-createfromformat
Nov 14, 2022
Merged

Make sure to not pass null to DateTime::createFromFormat#35157
come-nc merged 1 commit into
masterfrom
fix/avoid-passing-null-to-datetime-createfromformat

Conversation

@come-nc

Copy link
Copy Markdown
Contributor

Fix#35128

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nccome-nc self-assigned this Nov 14, 2022
@come-nccome-nc added the 3. to review Waiting for reviews label Nov 14, 2022
@come-nc
come-nc requested review from a team, PVince81, icewind1991, juliusknorr and szaimen and removed request for a teamNovember 14, 2022 15:25
@come-nccome-nc added this to the Nextcloud 26 milestone Nov 14, 2022

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable24

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable23

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@come-nc

Copy link
Copy Markdown
ContributorAuthor

(pushed here by mistake, fixing…)

@come-nc
come-ncforce-pushed the fix/avoid-passing-null-to-datetime-createfromformat branch from 6d31e87 to 9ba9f9aCompareNovember 14, 2022 16:08
@come-nc

Copy link
Copy Markdown
ContributorAuthor

(…fixed)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

3 participants

@come-nc@PVince81@szaimen