Uh oh!
There was an error while loading. Please reload this page.
[stable24] Properly compare quota against both float/int values - #35250
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
szaimen
requested review from
a team and blizzz
and removed request for
a teamNovember 21, 2022 15:33
icewind1991
approved these changes
Nov 21, 2022
juliusknorr
commented
Nov 23, 2022
MemberAuthor
/backport to stable23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
free_space may return an integer value instead of a float if the user has their quota set to 0.
Without this change users without quota were still able to touch empty files and create directories.
On master/stable25 this change was already introduced by https://github.com/nextcloud/server/pull/33600/files#diff-b89bc6bd7d5336d68032bb5a5c1f309df16f27173f9f58d9f338ec495d3f951bL230