Uh oh!
There was an error while loading. Please reload this page.
Fix misleading wording: searching is affected, not user access. - #3550
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
mention-bot
commented
Feb 20, 2017
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @davicente to be a potential reviewer. |
karlitschek
commented
Feb 20, 2017
Member
backport makes sense |
MorrisJobke
approved these changes
Feb 20, 2017
codecov-io
commented
Feb 20, 2017
Codecov Report
@@ Coverage Diff @@## master #3550 +/- ##
=========================================
Coverage 54.14% 54.14% Complexity 21039 21039 =========================================
Files 1306 1306 Lines 80298 80298 Branches 1250 1250 =========================================
Hits 43479 43479 Misses 36819 36819
Continue to review full report at Codecov.
|
LukasReschke
approved these changes
Feb 20, 2017
LukasReschke
commented
Feb 20, 2017
Member
@blizzz Can you open backports? THX! :) |
blizzz
commented
Feb 21, 2017
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says. Label fix, not a code one.
Since the wording is confusing and misleading, it is worth to backport this change. OKs, @karlitschek?