Skip to content

[stable24] Improve email results for sharing - #35713

Closed
backportbot-nextcloud[bot] wants to merge 3 commits into
stable24from
backport/35097/stable24
Closed

[stable24] Improve email results for sharing#35713
backportbot-nextcloud[bot] wants to merge 3 commits into
stable24from
backport/35097/stable24

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #35097

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Comment threadlib/private/User/Manager.php Fixed
skjnldsv

This comment was marked as resolved.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added the 3. to review Waiting for reviews label Dec 12, 2022
@blizzzblizzz mentioned this pull request Feb 6, 2023
@blizzz

Copy link
Copy Markdown
Member

Linter is unsatisfied

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not there yet

* @param string $uid
* @param bool $checkDataDirectory
* @throws \InvalidArgumentException Message is an already translated string with a reason why the id is not valid
* @since 26.0.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.0.whateveritwillbe

* @param string $uid The user ID to validate
* @param bool $checkDataDirectory Whether it should be checked if files for the ID exist inside the data directory
* @throws \InvalidArgumentException Message is an already translated string with a reason why the ID is not valid
* @since 26.0.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.0.whateveritwillbe

@blizzz

Copy link
Copy Markdown
Member

moving to 24.0.11

@blizzz

Copy link
Copy Markdown
Member

moving to 24.0.12

This was referenced Apr 13, 2023
@skjnldsvskjnldsv removed this from the Nextcloud 24.0.12 milestone Apr 18, 2023
@skjnldsvskjnldsv added this to the Nextcloud 24.0.13 milestone Apr 18, 2023
@juliusknorr

Copy link
Copy Markdown
Member

Shall we close this since 24 is EOL?

@blizzz

Copy link
Copy Markdown
Member

Shall we close this since 24 is EOL?

@nickvergessen for there is no traction since Dec is suppose there is no need more to have it in 24. Otherwise, please reopen and address reviews pls.

@blizzzblizzz closed this Jun 20, 2023
@nickvergessen
nickvergessen deleted the backport/35097/stable24 branch June 21, 2023 09:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz@juliusknorr@nickvergessen@skjnldsv@github-advanced-security