Include more information in iMIP email and show diff information on updating an event

[miaulalala]

• Resolves: part of Improve invitation update notification email calendar#3919

Summary

Instead of taking the date and time of the main recurrence, the changed VEVENT is filtered from the main VCALENDAR event and used to build a diff to accurately represent what changed.

Screenshots to follow

To Do

• Check if the logic is still sound if there is a recurrence that has a recurrence exception - what happens if I update the whole event - done, the logic is not sound yo
• Instead, filter old and new events and only leave what's been modified. Signifiers for this change are LAST-MODIFIED, SEQUENCE, RECURRENCE-ID / RRULE
• Build a visual diff for the email

As discussed with @ChristophWurst:

• Extract the event comparisons into its own service
• refactor the iMIP plugin to use that service instead of private methods
• make the data array backwards- compatible by introducing new array params for the new values and leaving the old ones unchanged (as templates that have overwritten ours might break otherwise)
• Adjust PHPUnit tests
  • ImipPluginTest
  • ImipServicetest

Testing manually

All events must have at least one attendee to trigger the iMIP logic

• Manually test with a single event - creating, updating
• Manually test with a new recurring event without a preexisting old event - test changing the main recurrence, creating a single or multiple recurrence exceptions in the middle
• Accept invitation via Mail app: Organizer should get an email that the invitation to the event was accepted (reply imip)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[miaulalala]

/backport to stable25

[miaulalala]

/backport to stable24

[miaulalala]

/backport to stable23

[ChristophWurst]

Code looks good

[miaulalala]

unfortunately, the approach with just the reccurence-id doesn't work correctly if I first update a single recurrence and then the whole instance.

[github-advanced-security]

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

[miaulalala]

I had a look, it's not in there yet. Will have to be a followup ticket due to time constraints this week. Sorry @onny

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin/stable24
# Create the new backport branch
git checkout -b fix/foo-stable24
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable23 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable23
git pull origin/stable23
# Create the new backport branch
git checkout -b fix/foo-stable23
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable23

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[miaulalala]

/backport to stable25

[miaulalala]

/backport to stable24

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin/stable24
# Create the new backport branch
git checkout -b fix/foo-stable24
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable23 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable23
git pull origin/stable23
# Create the new backport branch
git checkout -b fix/foo-stable23
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable23

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[st3iny]

/backport to stable25

[st3iny]

/backport to stable24