Uh oh!
There was an error while loading. Please reload this page.
Put Mimeloader insertion and read in the same transaction - #35744
Merged
Conversation
tcitworld
requested review from
a team, PVince81, come-nc, icewind1991 and nickvergessen
and removed request for
a teamDecember 13, 2022 08:55
tcitworld
commented
Dec 13, 2022
Uh oh!
There was an error while loading. Please reload this page.
tcitworldforce-pushed
the
mimeloader-transaction
branch
2 times, most recently
from
December 13, 2022 09:15
b655e41 to
532ace6Comparecome-nc
reviewed
Dec 13, 2022
Uh oh!
There was an error while loading. Please reload this page.
come-nc
reviewed
Dec 13, 2022
Uh oh!
There was an error while loading. Please reload this page.
come-nc
reviewed
Dec 13, 2022
Uh oh!
There was an error while loading. Please reload this page.
tcitworldforce-pushed
the
mimeloader-transaction
branch
from
December 14, 2022 08:30
532ace6 to
e6c7d64Comparecome-nc
approved these changes
Dec 15, 2022
tcitworldforce-pushed
the
mimeloader-transaction
branch
from
January 19, 2023 17:53
e6c7d64 to
de3fb63Comparetcitworldforce-pushed
the
mimeloader-transaction
branch
from
January 19, 2023 18:00
de3fb63 to
d69f74eCompareUh oh!
There was an error while loading. Please reload this page.
tcitworldforce-pushed
the
mimeloader-transaction
branch
from
January 20, 2023 13:53
d69f74e to
63088ceComparetcitworld
commented
Jan 20, 2023
MemberAuthor
Lint issues sound unrelated. |
Uh oh!
There was an error while loading. Please reload this page.
tcitworldforce-pushed
the
mimeloader-transaction
branch
from
January 23, 2023 09:22
63088ce to
18130abCompare
Comment on lines
-111
to
+116
| * @param int inserted ID | ||
| * @return int inserted ID |
nickvergessen
approved these changes
Jan 23, 2023
nickvergessen
commented
Jan 23, 2023
Member
Might have a negative performance impact, but no clue |
Merged
Merged
Merged
szaimen
commented
Apr 17, 2023
Contributor
/rebase |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
nextcloud-commandforce-pushed
the
mimeloader-transaction
branch
from
April 17, 2023 13:32
18130ab to
036cd47Compareszaimen
enabled auto-merge
April 17, 2023 13:36
come-nc
reviewed
May 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And modernize code a bit.
Checklist