Uh oh!
There was an error while loading. Please reload this page.
Phpunit warning fixes appframework - #358
Merged
Merged
Conversation
mention-bot
commented
Jul 10, 2016
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @BernhardPosselt and @DeepDiver1975 to be potential reviewers |
icewind1991
commented
Jul 10, 2016
Member
👍 ( |
| ->setConstructorArgs(['name']) | ||
| ->getMock(); | ||
| $this->api = $this->getMockBuilder('OC\AppFramework\Core\API') | ||
| ->setMethods([]) |
There was a problem hiding this comment.
you can just skip it ;) it was only needed because if the parameter order
nickvergessen
commented
Jul 10, 2016
Member
👍 |
* getMock is deprecated. * \PDOStatement mocking fails hard on phpunit 4.8
rullzerforce-pushed
the
phpunit-warning-fixes-appframework
branch
from
July 11, 2016 06:50
98c170b to
937c951Compare2 tasks
R0Wi pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of the ongoing effort the get clean unit tests of >=phpunit-5.4
CC: @MorrisJobke@nickvergessen@LukasReschke