ExifProvider.php: handle unhandled exception

[luxifr]

Signed-off-by: luxifr luxifer@luxifer.fyi

• Resolves: [Bug]: unhandled exception in ExifProvider crashes scan run #35931

Summary

Handle unhandled exception to keep files:scan run from crashing when it encounters a file with invalid exif data.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• [N/A] Screenshots before/after for front-end changes
• Documentation (manuals or wiki) is not required
• Backports requested where applicable (ex: critical bugfixes)

[marcelklehr]

I don't think this will work:

php > try {getimagesize('foobar');} catch(\Throwable $e){}
PHP Warning: getimagesize(foobar): Failed to open stream: No such file or directory in php shell code on line 1

[artonge]

Probably same reason as in #36420 (comment)

[come-nc]

This would work from scan command because scan command converts warning into Exception, but that’s really ugly. It should be handled in Scan command as it is the one doing the conversion.

[szaimen]

Same as in https://github.com/nextcloud/server/pull/36420/files

Suggested change

	$sizeResult = getimagesizefromstring($file->getContent());
	} catch (\Throwable$ex) {
	$this->logger->warning("Couldn't get image for ".$file->getId(), ['exception' => $ex]);
	$sizeResult = @getimagesizefromstring($file->getContent());
	} catch (\Exception$ex) {
	$this->logger->info("Couldn't get image for ".$file->getId(), ['exception' => $ex]);

[come-nc]

This would work from scan command because scan command converts warning into Exception, but that’s really ugly. It should be handled in Scan command as it is the one doing the conversion.

[come-nc]

See #37944 instead

[digidax]

Bug still present in 26.0.2 when using Android App Folder Sync: