Uh oh!
There was an error while loading. Please reload this page.
Ext storage configs default value support + enable SSL by default - #36089
Merged
Conversation
PVince81
requested review from
ArtificialOwl, artonge, come-nc, icewind1991 and nickvergessenJanuary 11, 2023 13:44
artonge
approved these changes
Jan 11, 2023
nickvergessen
approved these changes
Jan 11, 2023
PVince81
commented
Jan 11, 2023
MemberAuthor
/backport to stable25 |
PVince81
commented
Jan 11, 2023
MemberAuthor
/backport to stable24 |
PVince81
commented
Jan 11, 2023
MemberAuthor
/backport to stable23 |
nickvergessen
commented
Jan 12, 2023
Member
Can we retest for the SSO tests? |
PVince81
commented
Jan 12, 2023
MemberAuthor
pffff those env issues... restarted a second time |
Extend the external storage configuration parameters definition to allow to specify a default value Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81force-pushed
the
enh/noid/ext-storage-default-values
branch
from
January 13, 2023 09:27
344a824 to
4e179e0ComparePVince81
commented
Jan 13, 2023
MemberAuthor
fixed definition parameter unit test then squashed + rebased The SMB SSO tests will likely not boot because the env is broken (user_saml). The reason we don't always see that failure is because those tests don't always run due to conditions based on files_external code. |
PVince81
commented
Jan 16, 2023
MemberAuthor
I've raised #36163 to look into the SSO tests. I'll merge this now as SMB was not touched by this change. |
The backport to stable24 failed. Please do this backport manually. |
The backport to stable23 failed. Please do this backport manually. |
This was referenced Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist