Skip to content

Handle reminders where calendar name is null - #36217

Merged
szaimen merged 1 commit into
masterfrom
handle-push-notification-with-no-calendar-name
Apr 17, 2023
Merged

Handle reminders where calendar name is null#36217
szaimen merged 1 commit into
masterfrom
handle-push-notification-with-no-calendar-name

Conversation

@tcitworld

@tcitworldtcitworld commented Jan 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This adds an interface change, but that's not a public API. Backports should be acceptable, unless the new string to translate is not.

We're handling this in the providers and not in ReminderService because the fallback is translated with the user's language.

Checklist

@tcitworldtcitworld added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Jan 18, 2023
@tcitworldtcitworld added this to the Nextcloud 26 milestone Jan 18, 2023
@tcitworld
tcitworld requested a review from a teamJanuary 18, 2023 13:28
@tcitworldtcitworld self-assigned this Jan 18, 2023
@tcitworld
Handle reminders where calendar name is null
62739ec
This adds an interface change, but that's not a public API.
We're handling this in the providers and not in ReminderService because
the fallback is translated with the user's language.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
tcitworldforce-pushed the handle-push-notification-with-no-calendar-name branch from 4dc068b to 62739ecCompareJanuary 18, 2023 13:30
@tcitworld

tcitworld commented Jan 19, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@blizzzblizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzzblizzz mentioned this pull request Mar 7, 2023
Merged
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
@szaimen

szaimen commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Drone failure unrelated

@szaimen
szaimen merged commit e63720b into masterApr 17, 2023
@szaimen
szaimen deleted the handle-push-notification-with-no-calendar-name branch April 17, 2023 13:43
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 17, 2023
Merged
1 task
@tcitworld

tcitworld commented Apr 18, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 18, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@come-nccome-nccome-nc approved these changes

Assignees

@tcitworldtcitworld

Labels

3. to reviewWaiting for reviewsbugfeature: caldavRelated to CalDAV internals

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

6 participants

@tcitworld@szaimen@ChristophWurst@miaulalala@come-nc@blizzz