Skip to content

Multiple session start calls - #36239

Closed
the-djmaze wants to merge 5 commits into
nextcloud:masterfrom
the-djmaze:session_start
Closed

Multiple session start calls#36239
the-djmaze wants to merge 5 commits into
nextcloud:masterfrom
the-djmaze:session_start

Conversation

@the-djmaze

Copy link
Copy Markdown

OC\Session\Internal->clear() reopens the session several times as regenerateId() also reopens the sessions.
So it was like:

  • $this->reopen();
  • $this->regenerateId(); // $this->reopen();
  • $this->startSession(true);

Secondly the sessionClosed wasn't handled properly as read_and_close might or might not be used.

@szaimen
szaimen requested review from a team, ArtificialOwl, ChristophWurst, blizzz, icewind1991 and juliusknorr and removed request for a teamJanuary 19, 2023 09:18
@szaimenszaimen added this to the Nextcloud 26 milestone Jan 19, 2023
@szaimenszaimen added the 3. to review Waiting for reviews label Jan 19, 2023
Comment threadlib/private/Session/Internal.php
@blizzzblizzz mentioned this pull request Feb 1, 2023
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
@blizzzblizzz mentioned this pull request Mar 7, 2023
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 9, 2023
This was referenced May 3, 2023
@blizzzblizzz mentioned this pull request May 17, 2023
@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 23, 2023
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
djmazeand others added 2 commits November 20, 2023 12:19
Signed-off-by: the-djmaze <3752035+the-djmaze@users.noreply.github.com>
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsvskjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
@skjnldsvskjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@sorbaugh

sorbaugh commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

Hello @the-djmaze ! We're closing this PR as it seems that the original issue was solved with a different approach :)
Nevertheless, thank you so much for the time you put into this! Looking forward to any additional contributions!

@the-djmaze
the-djmaze deleted the session_start branch August 19, 2024 13:17
@the-djmaze

Copy link
Copy Markdown
Author

Good that it is solved 😉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressstaleTicket or PR with no recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: On Log out I always get: "... ignoring session_start() because a session is already active ..."

6 participants

@the-djmaze@sorbaugh@github-advanced-security@blizzz@skjnldsv@szaimen