Uh oh!
There was an error while loading. Please reload this page.
feat(app-framework): Add support for global middlewares - #36310
Merged
Conversation
This was referenced Jan 23, 2023
Uh oh!
There was an error while loading. Please reload this page.
1 task
ChristophWurstforce-pushed
the
feat/app-framework/global-middlewares
branch
from
January 25, 2023 16:44
775c29d to
7b6db59CompareChristophWurst
marked this pull request as ready for review
January 25, 2023 16:44
ChristophWurst
requested review from
ArtificialOwl, come-nc, juliusknorr, nickvergessen and skjnldsvJanuary 25, 2023 16:44
Uh oh!
There was an error while loading. Please reload this page.
nickvergessen
approved these changes
Jan 25, 2023
skjnldsv
approved these changes
Jan 26, 2023
ChristophWurstforce-pushed
the
feat/app-framework/global-middlewares
branch
from
January 26, 2023 08:57
cb80446 to
9a7e72dCompareChristophWurstforce-pushed
the
feat/app-framework/global-middlewares
branch
from
January 26, 2023 08:58
9a7e72d to
25cb6baCompareThis allows apps to register middlewares that always register, not just for the app's own requests Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurstforce-pushed
the
feat/app-framework/global-middlewares
branch
from
January 26, 2023 10:54
25cb6ba to
8d9af3eCompareChristophWurst
enabled auto-merge
January 26, 2023 12:21
nickvergessen
commented
Jan 26, 2023
Member
Should also go into #34692 but can be very short/brief there and link to the docs you already wrote 👏🏼 |
ChristophWurst
disabled auto-merge
January 26, 2023 14:16
MemberAuthor
{"reqId":"NeEXNBrFIRtQPBHf8LyF","level":3,"time":"2023-01-26T13:04:48+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"require_once(/drone/src/apps/spreed/composer/../vendor/autoload.php): Failed to open stream: No such file or directory at /drone/src/apps/spreed/composer/autoload.php#5","userAgent":"--","version":"26.0.0.3","data":{"app":"PHP"}} |
4 tasks
nickvergessen
commented
Jan 26, 2023
Member
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: an idea I had in my mind for years
Summary
This allows apps to register middlewares that always register, not just for the app's own requests. Example: ChristophWurst/nextcloud_sentry#329 and a middleware that monitors the performance of other apps' controller methods.
TODO
Checklist
required