Skip to content

feat(app-framework): Add support for global middlewares - #36310

Merged
ChristophWurst merged 1 commit into
masterfrom
feat/app-framework/global-middlewares
Jan 26, 2023
Merged

feat(app-framework): Add support for global middlewares#36310
ChristophWurst merged 1 commit into
masterfrom
feat/app-framework/global-middlewares

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Jan 23, 2023

Copy link
Copy Markdown
Member

Resolves: an idea I had in my mind for years

Summary

This allows apps to register middlewares that always register, not just for the app's own requests. Example: ChristophWurst/nextcloud_sentry#329 and a middleware that monitors the performance of other apps' controller methods.

TODO

Checklist

@ChristophWurstChristophWurst added enhancement 2. developing Work in progress integration pending documentation This pull request needs an associated documentation update labels Jan 23, 2023
@ChristophWurstChristophWurst added this to the Nextcloud 26 milestone Jan 23, 2023
@ChristophWurstChristophWurst self-assigned this Jan 23, 2023
@ChristophWurstChristophWurst changed the title Feat/app framework/global middlewares feat(app-framework): Add support for global middlewaresJan 23, 2023
Comment threadlib/private/AppFramework/Bootstrap/RegistrationContext.php Fixed
@ChristophWurstChristophWurst removed 2. developing Work in progress labels Jan 25, 2023
@ChristophWurst
ChristophWurstforce-pushed the feat/app-framework/global-middlewares branch from 775c29d to 7b6db59CompareJanuary 25, 2023 16:44
@ChristophWurstChristophWurst added 3. to review Waiting for reviews labels Jan 25, 2023
@ChristophWurst
ChristophWurst marked this pull request as ready for review January 25, 2023 16:44
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 25, 2023
@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 25, 2023
Comment threadlib/public/AppFramework/Bootstrap/IRegistrationContext.php
@ChristophWurstChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jan 26, 2023
@ChristophWurst
ChristophWurstforce-pushed the feat/app-framework/global-middlewares branch from cb80446 to 9a7e72dCompareJanuary 26, 2023 08:57
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2023
@ChristophWurst
ChristophWurstforce-pushed the feat/app-framework/global-middlewares branch from 9a7e72d to 25cb6baCompareJanuary 26, 2023 08:58
This allows apps to register middlewares that always register, not just
for the app's own requests
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the feat/app-framework/global-middlewares branch from 25cb6ba to 8d9af3eCompareJanuary 26, 2023 10:54
@nickvergessen

Copy link
Copy Markdown
Member

Should also go into #34692 but can be very short/brief there and link to the docs you already wrote 👏🏼

@ChristophWurst

ChristophWurst commented Jan 26, 2023

Copy link
Copy Markdown
MemberAuthor
{"reqId":"NeEXNBrFIRtQPBHf8LyF","level":3,"time":"2023-01-26T13:04:48+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"require_once(/drone/src/apps/spreed/composer/../vendor/autoload.php): Failed to open stream: No such file or directory at /drone/src/apps/spreed/composer/autoload.php#5","userAgent":"--","version":"26.0.0.3","data":{"app":"PHP"}}

@nickvergessen 👀

nextcloud/spreed#8578?

@ChristophWurst
ChristophWurst merged commit ad00a14 into masterJan 26, 2023
@ChristophWurst
ChristophWurst deleted the feat/app-framework/global-middlewares branch January 26, 2023 14:17
@nickvergessen

Copy link
Copy Markdown
Member

#36389

@blizzzblizzz mentioned this pull request Feb 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementintegration

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@nickvergessen@skjnldsv@github-advanced-security