Skip to content

Adapt native tooltip for new structure of NcAvatar - #36358

Merged
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing
Feb 28, 2023
Merged

Adapt native tooltip for new structure of NcAvatar#36358
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing

Conversation

@JuliaKirschenheuter

@JuliaKirschenheuterJuliaKirschenheuter commented Jan 25, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves: #36357

Summary

Remove title and aria-label attributes from NcAvatar components in files_sharing.

BeforeAfter
Screenshot from 2023-01-25 15-26-14Screenshot from 2023-01-25 15-22-51
Screenshot from 2023-01-25 15-25-58Screenshot from 2023-01-25 15-23-03

Checklist

@nickvergessen

nickvergessen commented Jan 25, 2023

Copy link
Copy Markdown
Member

Conflicting files
dist/files_sharing-files_sharing_tab.js
dist/files_sharing-files_sharing_tab.js.map

nickvergessen
nickvergessen reviewed Jan 25, 2023
View reviewed changes
Comment threadapps/files_sharing/src/components/SharingEntry.vue Outdated
@JuliaKirschenheuter
JuliaKirschenheuter marked this pull request as draft January 26, 2023 08:39
@JuliaKirschenheuterJuliaKirschenheuter added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 26, 2023
@JuliaKirschenheuterJuliaKirschenheuter mentioned this pull request Jan 26, 2023
Merged
2 tasks
@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch from c49f8da to e74f43cCompareFebruary 24, 2023 15:23
@JuliaKirschenheuter
JuliaKirschenheuter marked this pull request as ready for review February 24, 2023 15:23
@JuliaKirschenheuter

JuliaKirschenheuter commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

can't do /backport to stable25 yet because stable25 has "@nextcloud/vue": "^7.5.0" https://github.com/nextcloud/server/blob/stable25/package.json#L49. Needed version: https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.6.0

@JuliaKirschenheuterJuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 24, 2023
@Pytal

Pytal commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member

can't do /backport to stable25 yet because stable25 has "@nextcloud/vue": "^7.5.0" stable25/package.json#L49. Needed version: nextcloud/nextcloud-vue@v7.6.0 (release)

@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch from e74f43c to 9be573aCompareFebruary 27, 2023 14:06
@JuliaKirschenheuter
Adapt native tooltip for new structure of NcAvatar
76999d1
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch from 9be573a to 76999d1CompareFebruary 27, 2023 14:41
@JuliaKirschenheuter
JuliaKirschenheuter merged commit 28e35ba into masterFeb 28, 2023
@JuliaKirschenheuter
JuliaKirschenheuter deleted the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch February 28, 2023 10:19
@JuliaKirschenheuter

JuliaKirschenheuter commented Feb 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 28, 2023
Merged
1 task
@blizzzblizzz mentioned this pull request Mar 2, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@artongeartongeartonge approved these changes
@PytalPytalPytal approved these changes
@szaimenszaimenAwaiting requested review from szaimen

Assignees

@JuliaKirschenheuterJuliaKirschenheuter

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BITV]: Adapt tooltips on NcAvatar for files_sharing

4 participants

@JuliaKirschenheuter@nickvergessen@Pytal@artonge