Uh oh!
There was an error while loading. Please reload this page.
chore: drop depedency php-parser - #36393
Merged
Merged
Conversation
vitormattos
approved these changes
Jan 27, 2023
kesselb
commented
Jan 27, 2023
ContributorAuthor
Failing integration-sharing-v1-video-verification should be fixed by #36389. |
nickvergessen
requested changes
Jan 27, 2023
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Currently brings in Symfony Mailer change. So this is blocked by #30349
kesselb
commented
Jan 27, 2023
ContributorAuthor
Thanks, added a Todo to wait for #30349. |
Merged
blizzz
commented
Feb 2, 2023
Member
Just merged |
nickvergessen
commented
Feb 2, 2023
Member
Taking over since kessel is sick |
nickvergessenforce-pushed
the
3rdparty-drop-php-parser
branch
from
February 2, 2023 11:08
2a875e2 to
26b34feCompareSigned-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
nickvergessenforce-pushed
the
3rdparty-drop-php-parser
branch
from
February 2, 2023 11:42
26b34fe to
d923565Comparenickvergessen
commented
Feb 2, 2023
Member
Repushed to have |
nickvergessen
approved these changes
Feb 2, 2023
nickvergessen
enabled auto-merge
February 2, 2023 13:10
nickvergessen
commented
Feb 2, 2023
Member
@kesselb please take care of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dear php-parser,
You were a great help to check that apps are compliant and we did not forget the since and deprecated annotations.
Thank you for all the service you provided us over the years.
TODO
Checklist