Uh oh!
There was an error while loading. Please reload this page.
feat(theming): Only convert a background image if it benefits from it - #36471
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* WebP images are generally quite small, converting to pngs would increase the filesize a lot. * Small JPEG and PNG images do not benefit from any conversion, so skip it. * JPEG images will get quite bigger when converted to PNG so instead convert to progressive JPEG Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnuxforce-pushed
the
fix/theming-keep-images
branch
from
February 20, 2023 12:11
cd51d78 to
2c28a48CompareThere was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnuxforce-pushed
the
fix/theming-keep-images
branch
from
February 20, 2023 13:57
2c28a48 to
2ca1153Compareszaimen
requested review from
a team, ArtificialOwl and icewind1991
and removed request for
a teamFebruary 20, 2023 21:05
juliusknorr
approved these changes
Feb 21, 2023
Merged
szaimen
commented
Mar 1, 2023
Contributor
skjnldsv
approved these changes
Mar 1, 2023
This was referenced Mar 1, 2023
Merged
ornanovitch
commented
Mar 26, 2023
Contributor
Hey @skjnldsv, could this be backported to 25? That would be very useful. Thanks! |
artonge
commented
Jan 18, 2024
Collaborator
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This also fixes the wrong mime type sent to the browser, as before this every non gif, non svg would have been converted to a png. But the server sent the file extension as the mime type. Now the file type is preserved and only converted to the same file type.
Checklist