Skip to content

[stable24] Skip failing avatar test with PHP 8.0 - #36500

Merged
nickvergessen merged 1 commit into
stable24from
bugfix/noid/green-ci
Feb 3, 2023
Merged

[stable24] Skip failing avatar test with PHP 8.0#36500
nickvergessen merged 1 commit into
stable24from
bugfix/noid/green-ci

Conversation

@nickvergessen

@nickvergessennickvergessen commented Feb 2, 2023

Copy link
Copy Markdown
Member

The font is placed one pixel off

Better skipping then ignoring red CI

ExpectedActual (font is one pixel top and right)
guest_avatar_einstein_32guest_avatar_einstein_32-new

@nickvergessennickvergessen added the 3. to review Waiting for reviews label Feb 2, 2023
@nickvergessennickvergessen added this to the Nextcloud 24.0.10 milestone Feb 2, 2023
@nickvergessen
nickvergessen requested a review from a teamFebruary 2, 2023 13:01
@nickvergessennickvergessen self-assigned this Feb 2, 2023
@nickvergessen
nickvergessen requested review from ArtificialOwl, blizzz and icewind1991 and removed request for a teamFebruary 2, 2023 13:01
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 2, 2023
The font is placed one pixel off
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessen merged commit 5bde3e3 into stable24Feb 3, 2023
@nickvergessen
nickvergessen deleted the bugfix/noid/green-ci branch February 3, 2023 11:55
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@artonge@miaulalala@blizzz