Uh oh!
There was an error while loading. Please reload this page.
[stable24] perf(federation): Only request root share info for checking availability - #36558
Merged
Conversation
Otherwise this would request a full recursive dirctory listing while the result is never being used Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
a team, ArtificialOwl, artonge, blizzz and icewind1991
and removed request for
a teamFebruary 6, 2023 10:13
artonge
approved these changes
Feb 6, 2023
Merged
blizzz
approved these changes
Feb 7, 2023
| @@ -65,7 +65,7 @@ public function __construct(string $appName, | |||
| * @param null $dir | |||
Member
There was a problem hiding this comment.
also here, old php doc seems to confuse psalm
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
backport/36557/stable24
branch
from
February 7, 2023 14:16
fbf5f34 to
a5a5a78Comparejuliusknorr
commented
Feb 7, 2023
MemberAuthor
Removed the phpdoc annotations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #36452