Skip to content

feat(translations): Add translation provider API - #36584

Merged
juliusknorr merged 1 commit into
masterfrom
enh/translation-api
Feb 27, 2023
Merged

feat(translations): Add translation provider API#36584
juliusknorr merged 1 commit into
masterfrom
enh/translation-api

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Feb 7, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

TODO

  • Wrap registration into app bootstrap for lazyness
  • Clarify if defined API makes sense
  • Improve error handling

Checklist

github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 7, 2023
View reviewed changes
Comment threadlib/private/Translation/TranslationManager.php Fixed
Comment threadlib/private/Translation/TranslationManager.php Fixed
marcelklehr
marcelklehr reviewed Feb 7, 2023
View reviewed changes
Comment threadlib/public/Translation/ITranslationProvider.php
marcelklehr
marcelklehr reviewed Feb 7, 2023
View reviewed changes
Comment threadlib/private/Translation/TranslationManager.php Outdated
marcelklehr
marcelklehr reviewed Feb 10, 2023
View reviewed changes
Comment threadlib/public/Translation/ITranslationManager.php
marcelklehr
marcelklehr reviewed Feb 10, 2023
View reviewed changes
Comment threadlib/public/Translation/ITranslationManager.php Outdated
juliusknorr
juliusknorr commented Feb 13, 2023
View reviewed changes
Comment threadlib/public/Translation/ITranslationProvider.php Outdated
@tcitworld

tcitworld commented Feb 13, 2023

Copy link
Copy Markdown
Member

Most providers accept translating full documents, maybe add an extra interface for those?

github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 21, 2023
View reviewed changes
Comment threadlib/public/Translation/ITranslationManager.php Fixed
marcelklehr
marcelklehr reviewed Feb 21, 2023
View reviewed changes
Comment threadlib/private/Translation/TranslationManager.php Outdated
@juliusknorrjuliusknorr added this to the Nextcloud 26 milestone Feb 21, 2023
@juliusknorr

juliusknorr commented Feb 21, 2023

Copy link
Copy Markdown
MemberAuthor

Most providers accept translating full documents, maybe add an extra interface for those?

Might be a nice idea for a follow up extension, for now I'd like to keep this PR as simple as possible.

marcelklehr
marcelklehr reviewed Feb 21, 2023
View reviewed changes
Comment threadlib/private/Translation/TranslationManager.php
julien-nc
julien-nc approved these changes Feb 23, 2023
View reviewed changes

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Apart from my small comments: 👍

Comment threadlib/private/Translation/TranslationManager.php Outdated
Comment threadlib/private/Translation/TranslationManager.php Outdated
@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
Merged
@juliusknorr
feat(translations): Add translation provider API
3e63298
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added the 4. to release Ready to be released and/or waiting for tests to finish label Feb 27, 2023
@juliusknorr
juliusknorr marked this pull request as ready for review February 27, 2023 16:28
@juliusknorr
juliusknorr merged commit 6cfd53a into masterFeb 27, 2023
@juliusknorr
juliusknorr deleted the enh/translation-api branch February 27, 2023 18:45
@juliusknorrjuliusknorr mentioned this pull request Feb 28, 2023
Merged
4 tasks
@blizzzblizzz mentioned this pull request Mar 2, 2023
Merged
@nickvergessennickvergessen mentioned this pull request Apr 17, 2023
Merged
@nickvergessen

nickvergessen commented Apr 17, 2023

Copy link
Copy Markdown
Member

Missing API docs are in nextcloud/documentation#10047

@marcelklehrmarcelklehr mentioned this pull request Apr 20, 2023
Closed
@marcelklehrmarcelklehr mentioned this pull request Apr 20, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehrmarcelklehrmarcelklehr approved these changes
@julien-ncjulien-ncjulien-nc approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

6 participants

@juliusknorr@tcitworld@nickvergessen@marcelklehr@julien-nc@github-advanced-security