Skip to content

Create an accessible name for logo on logged in page - #36633

Merged
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/36632-create_an_accessible_name_for_logo
Feb 13, 2023
Merged

Create an accessible name for logo on logged in page#36633
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/36632-create_an_accessible_name_for_logo

Conversation

@JuliaKirschenheuter

@JuliaKirschenheuterJuliaKirschenheuter commented Feb 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Create invisible accessible name for logo. No visible changes.

BeforeAfter
Screenshot from 2023-02-09 14-05-03Screenshot from 2023-02-09 14-00-58

Checklist

@JuliaKirschenheuterJuliaKirschenheuter added the 3. to review Waiting for reviews label Feb 9, 2023
@JuliaKirschenheuterJuliaKirschenheuter self-assigned this Feb 9, 2023
@JuliaKirschenheuter

JuliaKirschenheuter commented Feb 9, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/36632-create_an_accessible_name_for_logo branch from b5cb72d to 5212f30CompareFebruary 9, 2023 13:09
@nickvergessen
nickvergessen removed their request for review February 9, 2023 13:45
Pytal
Pytal reviewed Feb 9, 2023
View reviewed changes
Comment threadcore/templates/layout.user.php Outdated
@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/36632-create_an_accessible_name_for_logo branch from 5212f30 to 077625dCompareFebruary 10, 2023 13:55
nickvergessen
nickvergessen reviewed Feb 10, 2023
View reviewed changes
Comment threadcore/templates/layout.user.php Outdated
@JuliaKirschenheuter
Create an accessible name for logo on logged in page
2b39261
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/36632-create_an_accessible_name_for_logo branch from 81232c2 to 2b39261CompareFebruary 13, 2023 08:18
@JuliaKirschenheuter
JuliaKirschenheuter merged commit 9160b37 into masterFeb 13, 2023
@JuliaKirschenheuter
JuliaKirschenheuter deleted the fix/36632-create_an_accessible_name_for_logo branch February 13, 2023 09:32
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 13, 2023
Merged
@blizzzblizzz mentioned this pull request Feb 13, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@artongeartongeartonge approved these changes
@PytalPytalPytal approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@szaimenszaimenAwaiting requested review from szaimen

Assignees

@JuliaKirschenheuterJuliaKirschenheuter

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create an accessible name for logo on logged in page

4 participants

@JuliaKirschenheuter@nickvergessen@artonge@Pytal