Uh oh!
There was an error while loading. Please reload this page.
Safer URL match in FileReferenceProvider - #36637
Merged
Merged
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
commented
Feb 9, 2023
MemberAuthor
This can be safely backported to stable25 IMO. |
juliusknorr
approved these changes
Feb 9, 2023
juliusknorr
commented
Feb 9, 2023
Member
/backport to stable25 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was matching URLs like
https://instance.yours/apps/files_sharing/accept/ocinternal:123456.Also, it was crashing when the URL does not have any query params.