Skip to content

Create headings for apps, users, settings pages - #36640

Merged
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/35626-No_heading_nor_tab_index_for_settings_pages
Mar 8, 2023
Merged

Create headings for apps, users, settings pages#36640
JuliaKirschenheuter merged 1 commit into
masterfrom
fix/35626-No_heading_nor_tab_index_for_settings_pages

Conversation

@JuliaKirschenheuter

@JuliaKirschenheuterJuliaKirschenheuter commented Feb 9, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Create headings for settings, users and apps pages. No visible changes.

After

Screenshot from 2023-02-13 15-45-16
Screenshot from 2023-02-13 15-45-45

Checklist

@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch from 1c57a68 to 0f73b90CompareFebruary 10, 2023 13:06
@JuliaKirschenheuterJuliaKirschenheuter added the 3. to review Waiting for reviews label Feb 10, 2023
@JuliaKirschenheuter

JuliaKirschenheuter commented Feb 10, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@JuliaKirschenheuter
JuliaKirschenheuter marked this pull request as ready for review February 10, 2023 13:25
@JuliaKirschenheuterJuliaKirschenheuter changed the title Fix/35626 no heading nor tab index for settings pagesFix/35626 no heading nor tab index for apps, users, settings pagesFeb 10, 2023
nickvergessen
nickvergessen requested changes Feb 10, 2023
View reviewed changes
Comment threadapps/settings/src/router.js Outdated
Comment threadcore/templates/layout.user.php Outdated
Comment threadcore/templates/layout.user.php Outdated
Comment threadcore/templates/layout.user.php Outdated
@JuliaKirschenheuterJuliaKirschenheuter changed the title Fix/35626 no heading nor tab index for apps, users, settings pagesCreate headings for apps, users, settings pagesFeb 13, 2023
@JuliaKirschenheuter
JuliaKirschenheuter marked this pull request as draft February 13, 2023 14:44
@JuliaKirschenheuterJuliaKirschenheuter added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 13, 2023
@JuliaKirschenheuterJuliaKirschenheuter mentioned this pull request Feb 13, 2023
Closed
9 tasks
This was referenced Mar 2, 2023
Merged
Merged
@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch 3 times, most recently from 5380d0f to 2ab6bc3CompareMarch 2, 2023 10:36
@JuliaKirschenheuter
JuliaKirschenheuter marked this pull request as ready for review March 2, 2023 10:36
@JuliaKirschenheuterJuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 2, 2023
ChristophWurst
ChristophWurst requested changes Mar 2, 2023
View reviewed changes
Comment threadapps/settings/src/router.js Outdated
Comment threadcore/src/OCP/accessibility.js Outdated
Comment threadcore/src/OCP/accessibility.js Outdated
@ChristophWurstChristophWurst added the pending documentation This pull request needs an associated documentation update label Mar 2, 2023
@ChristophWurst

ChristophWurst commented Mar 2, 2023

Copy link
Copy Markdown
Member

The new OCP.Accessibility function should go into the developer documentation

ChristophWurst
ChristophWurst reviewed Mar 2, 2023
View reviewed changes
Comment threadapps/settings/src/router.js Outdated
@nickvergessen
nickvergessen removed their request for review March 3, 2023 11:37
@JuliaKirschenheuter

JuliaKirschenheuter commented Mar 3, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

ChristophWurst
ChristophWurst reviewed Mar 6, 2023
View reviewed changes
Comment threadcore/src/OCP/accessibility.js Outdated
Comment threadcore/src/OCP/accessibility.js
Comment threadcore/templates/layout.user.php Outdated
ChristophWurst
ChristophWurst approved these changes Mar 6, 2023
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch 2 times, most recently from 4253177 to c73c945CompareMarch 6, 2023 11:48
@ChristophWurst

ChristophWurst commented Mar 6, 2023

Copy link
Copy Markdown
Member

Let's stick with fixups until the second approval and passing CI (with the exception of the fixup check)

Bildschirmfoto vom 2023-03-06 13-07-07

^ makes it very hard to follow your latest pushes

artonge
artonge approved these changes Mar 6, 2023
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, else it looks good :)

Comment threadcore/src/OCP/accessibility.js Outdated
@nickvergessen
nickvergessen removed their request for review March 6, 2023 16:33
@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch from 0a5e835 to daae060CompareMarch 7, 2023 16:12
@JuliaKirschenheuter
Create headings for settings pages
0cfbe54
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the fix/35626-No_heading_nor_tab_index_for_settings_pages branch from daae060 to 0cfbe54CompareMarch 7, 2023 16:51
@JuliaKirschenheuter
JuliaKirschenheuter merged commit f1abecd into masterMar 8, 2023
@JuliaKirschenheuter
JuliaKirschenheuter deleted the fix/35626-No_heading_nor_tab_index_for_settings_pages branch March 8, 2023 07:08
This was referenced Mar 8, 2023
Merged
Merged
@JuliaKirschenheuterJuliaKirschenheuter mentioned this pull request Mar 9, 2023
Closed
2 tasks
@DaphneMuller

DaphneMuller commented May 30, 2023

Copy link
Copy Markdown
Contributor

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen requested changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@PytalPytalPytal approved these changes
@szaimenszaimenAwaiting requested review from szaimen
@artongeartongeAwaiting requested review from artonge

Assignees

@JuliaKirschenheuterJuliaKirschenheuter

Labels

3. to reviewWaiting for reviewspending documentationThis pull request needs an associated documentation update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BITV] No heading for settings pages

6 participants

@JuliaKirschenheuter@ChristophWurst@DaphneMuller@nickvergessen@artonge@Pytal