Uh oh!
There was an error while loading. Please reload this page.
Port admin delegation selects - #36650
Merged
Merged
Conversation
Pytal
requested review from
JuliaKirschenheuter, artonge, szaimen and tcitworldFebruary 10, 2023 01:52
Pytal
commented
Feb 10, 2023
MemberAuthor
/backport to stable25 |
2 tasks
| $settings = array_merge( | ||
| $settings, | ||
| array_map(function (IDelegatedSettings $setting) use ($section) { | ||
| $sectionName = $section->getName() . ($setting->getName() !== null ? ' - ' . $setting->getName() : ''); |
Check notice
Code scanning / Psalm
PossiblyNullOperand
artonge
approved these changes
Feb 13, 2023
Merged
Pytalforce-pushed
the
enh/a11y-admin-delegation-select
branch
from
February 24, 2023 01:16
efc20d1 to
4690d15ComparePytal
commented
Feb 24, 2023
MemberAuthor
Rebased |
artonge
approved these changes
Feb 27, 2023
Pytal
commented
Feb 28, 2023
MemberAuthor
💡 would be nice if the double approve counted as two separate ones |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
enh/a11y-admin-delegation-select
branch
from
March 1, 2023 00:09
4690d15 to
db5d5c1Compare1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist