Uh oh!
There was an error while loading. Please reload this page.
Add parent index on filecache - #36701
Merged
Merged
Conversation
artonge
commented
Feb 14, 2023
CollaboratorAuthor
/backport to stable25 |
artonge
commented
Feb 14, 2023
CollaboratorAuthor
/backport to stable24 |
icewind1991
approved these changes
Feb 15, 2023
icewind1991
previously requested changes
Feb 15, 2023
icewind1991
left a comment
Member
There was a problem hiding this comment.
Also needs to be added to the migration that creates the filecache table
artongeforce-pushed
the
artonge/feat/fc_parent_index
branch
from
February 15, 2023 14:58
32bbce6 to
407ff41Compareartonge
commented
Feb 16, 2023
CollaboratorAuthor
Waiting for more practical feedbacks before moving on. |
icewind1991
approved these changes
Feb 22, 2023
szaimen
requested review from
a team, ArtificialOwl, blizzz and juliusknorr
and removed request for
a teamFebruary 22, 2023 14:39
juliusknorr
commented
Feb 22, 2023
Member
Can you outline or do you have a reference why the single index would be faster? At least from the explain there seems to be no difference. |
Merged
icewind1991
commented
Feb 23, 2023
Member
It seems that the size of the parent_name_hash index is causing performance issues |
juliusknorr
approved these changes
Feb 23, 2023
Merged
szaimen
commented
Mar 20, 2023
Contributor
/rebase |
szaimen
enabled auto-merge
March 20, 2023 14:44
Signed-off-by: Louis Chemineau <louis@chmn.me>
nextcloud-commandforce-pushed
the
artonge/feat/fc_parent_index
branch
from
March 20, 2023 15:03
407ff41 to
bda66f9Comparejuliusknorr
disabled auto-merge
March 21, 2023 07:32
juliusknorr
commented
Mar 21, 2023
Member
Failure unrelated |
szaimen
commented
Mar 21, 2023
Contributor
/backport to stable26 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To speed up:
server/lib/private/Files/Cache/Cache.php
Lines 878 to 880 in fd2afe6
The current query uses the
parent_name_hashindex, which is not optimal with long names.