Uh oh!
There was an error while loading. Please reload this page.
Revert "fix(performance): Do not set up filesystem on every call" - #36788
Merged
Conversation
nickvergessen
commented
Feb 21, 2023
Member
- Reverts fix(performance): Do not set up filesystem on every call #36589
- Details in Regression in filesystem handling breaks Talk/ attachment folder #36787
| throw new NotImplemented($this->l10n->t('Invalid chunk name')); | ||
| } | ||
| $chunk_handler = new \OC_FileChunking($info); |
Check notice
Code scanning / Psalm
UndefinedFunction
| $targetPath = $path . '/' . $info['name']; | ||
| /** @var \OC\Files\Storage\Storage $targetStorage */ | ||
| [$targetStorage, $targetInternalPath] = $this->fileView->resolvePath($targetPath); | ||
Check notice
Code scanning / Psalm
DeprecatedClass
| $this->fileView->unlockFile($targetPath, ILockingProvider::LOCK_SHARED); | ||
| return $info->getEtag(); | ||
| } catch (\Exception $e) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
| $this->fileView->unlockFile($targetPath, ILockingProvider::LOCK_SHARED); | ||
| return $info->getEtag(); | ||
| } catch (\Exception $e) { |
Check notice
Code scanning / Psalm
PossiblyFalseReference
| } | ||
| $this->convertToSabreException($e); | ||
| } | ||
| } |
Check notice
Code scanning / Psalm
PossiblyFalseReference
| // chunked upload handling | ||
| if (isset($_SERVER['HTTP_OC_CHUNKED'])) { | ||
| [$path, $name] = \Sabre\Uri\split($filePath); | ||
| $info = \OC_FileChunking::decodeName($name); |
Check notice
Code scanning / Psalm
UndefinedFunction
| $dir = ''; | ||
| } | ||
| $info = \OC_FileChunking::decodeName($name); |
Check notice
Code scanning / Psalm
UndefinedFunction
| return true; | ||
| } | ||
| public function getFileChunking($info) { |
Check notice
Code scanning / Psalm
MissingReturnType
| return true; | ||
| } | ||
| public function getFileChunking($info) { |
Check notice
Code scanning / Psalm
MissingParamType
juliusknorr
approved these changes
Feb 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.