Skip to content

do onetime user setup before getting any mount from providers - #36810

Merged
icewind1991 merged 1 commit into
masterfrom
setup-user-onetime-before-mounts
Mar 24, 2023
Merged

do onetime user setup before getting any mount from providers#36810
icewind1991 merged 1 commit into
masterfrom
setup-user-onetime-before-mounts

Conversation

@icewind1991

Copy link
Copy Markdown
Member

this fixes a race condition where wrappers weren't properly applied if when a mount provider creates the storage instance one mountpoint creation instead of lazily

To test:

  • Setup an instance with encryption enabled, groupfolders and text
  • Enable groupfolder encryption: occ config:app:set groupfolders enable_encryption --value true
  • Create a groupfolder and navigate into it
  • Click the "Add notes, lists, or links..." in the webui to create a Readme.md in the folder
  • Check if the text editor gets filled with an encrypted blob or an empty textfile

this fixes a race condition where wrappers weren't properly applied if when a mount provider creates the storage instance one mountpoint creation instead of lazily
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Feb 22, 2023
@icewind1991icewind1991 added this to the Nextcloud 26 milestone Feb 22, 2023
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, blizzz and come-nc and removed request for a teamFebruary 22, 2023 17:06
@icewind1991
icewind1991 marked this pull request as ready for review February 22, 2023 17:13
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

@skjnldsvskjnldsv mentioned this pull request Feb 23, 2023
@blizzzblizzz mentioned this pull request Mar 7, 2023
@blizzzblizzz modified the milestones: Nextcloud 26, Nextcloud 27Mar 7, 2023
@blizzz

Copy link
Copy Markdown
Member

/backport to stable26

@Pytal

Copy link
Copy Markdown
Member

Backportable to stable24@icewind1991?

@Pytal

Copy link
Copy Markdown
Member

/backport to stable24

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@blizzz@Pytal@skjnldsv@come-nc