Skip to content

Make sure to never trigger files hooks on a null path - #36893

Merged
come-nc merged 1 commit into
masterfrom
fix/avoid-file-events-on-null-path
May 9, 2023
Merged

Make sure to never trigger files hooks on a null path#36893
come-nc merged 1 commit into
masterfrom
fix/avoid-file-events-on-null-path

Conversation

@come-nc

@come-nccome-nc commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Summary

File pre/post operation events should only be triggered for files inside the default view.
For other files a bogus event with a null path was fired, this avoids that.

Checklist

@come-nccome-nc added the 2. developing Work in progress label Feb 28, 2023
@come-nccome-nc self-assigned this Feb 28, 2023
@come-nccome-nc added this to the Nextcloud 27 milestone Feb 28, 2023
@come-nccome-nc added the bug label Feb 28, 2023
Comment threadapps/dav/lib/Connector/Sabre/File.php Fixed
Comment threadapps/dav/lib/Connector/Sabre/File.php Fixed
@come-nc

come-nc commented Feb 28, 2023

Copy link
Copy Markdown
ContributorAuthor

@tram98

Copy link
Copy Markdown

Thank you so much for the fix. I am really needing this fix because of issues with syncing bigger files.

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/rebase

@nextcloud-command
nextcloud-commandforce-pushed the fix/avoid-file-events-on-null-path branch from 8843759 to 1021d03CompareApril 5, 2023 10:11
@come-nc
come-nc marked this pull request as ready for review April 24, 2023 13:00
@come-nccome-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2023
@come-nc
come-nc requested review from a team, ArtificialOwl, blizzz and icewind1991 and removed request for a teamApril 24, 2023 13:01
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/rebase

@come-nc
come-nc requested review from artonge and susnux and removed request for blizzzMay 2, 2023 16:02
Comment threadapps/dav/lib/Connector/Sabre/File.php
@nextcloud-command
nextcloud-commandforce-pushed the fix/avoid-file-events-on-null-path branch from 1021d03 to 52902efCompareMay 2, 2023 16:59
@skjnldsvskjnldsv mentioned this pull request May 3, 2023
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/rebase

@dinosmm

Copy link
Copy Markdown

Apologies for my lack of experience with GitHub and NC development, but will this only be pushed into Nextcloud 27 and not in a 26.0.x patch?

@susnux

Copy link
Copy Markdown
Contributor

will this only be pushed into Nextcloud 27 and not in a 26.0.x patch?

Yes this will first be pushed into Nextcloud 27 and might then be backported to 26.0.x.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command
nextcloud-commandforce-pushed the fix/avoid-file-events-on-null-path branch from 52902ef to 6034cc6CompareMay 4, 2023 17:55
@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2023
This was referenced May 9, 2023
@come-nc
come-nc merged commit 185fe53 into masterMay 9, 2023
@come-nc
come-nc deleted the fix/avoid-file-events-on-null-path branch May 9, 2023 15:44
@solracsf

Copy link
Copy Markdown
Member

@come-nc OK to be backported?

@come-nc

Copy link
Copy Markdown
ContributorAuthor

Hum yeah psalm will complain about the backports I think because typing was hell, but let’s try it.

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: strpos() and/or pathinfo(): Passing null to parameter #1 ($haystack) of type string is deprecated

9 participants

@come-nc@tram98@dinosmm@susnux@solracsf@icewind1991@artonge@github-advanced-security@blizzz