Skip to content

[Stable9] Make theming work with pretty URLs - #370

Merged
MariusBluem merged 2 commits into
stable9from
stable9-backport-361
Jul 12, 2016
Merged

[Stable9] Make theming work with pretty URLs #370
MariusBluem merged 2 commits into
stable9from
stable9-backport-361

Conversation

@oparoz

@oparozoparoz commented Jul 11, 2016•
edited
Loading

Copy link
Copy Markdown
Member

oparoz added 2 commits July 11, 2016 17:42
oparoz
Make theming work with pretty URLs
1f28ed8
In some envs the rewrite rules for pretty URLs apply to all CSS files, so let's not end the route name with that etension.
Fixes#315
(cherry picked from commit 839ee5e)
oparoz
Fix tests
3c0ba18
(cherry picked from commit eceb0db)
@oparozoparoz added bug 3. to review Waiting for reviews labels Jul 11, 2016
@oparozoparoz added this to the Nextcloud 9.0.53 milestone Jul 11, 2016
@oparozoparoz self-assigned this Jul 11, 2016
@mention-bot

mention-bot commented Jul 11, 2016

Copy link
Copy Markdown

@oparoz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle and @LukasReschke to be potential reviewers

@oparozoparoz mentioned this pull request Jul 11, 2016
Merged
@LukasReschke

LukasReschke commented Jul 11, 2016

Copy link
Copy Markdown
Member

LGTM. Thanks @oparoz 🚀

@MariusBluem

MariusBluem commented Jul 12, 2016

Copy link
Copy Markdown
Member

Let's do this 👍

@MariusBluem
MariusBluem merged commit d35d9d2 into stable9Jul 12, 2016
@MariusBluem
MariusBluem deleted the stable9-backport-361 branch July 12, 2016 04:59
@LukasReschkeLukasReschke mentioned this pull request Jul 14, 2016
Closed
@oparozoparoz removed the 3. to review Waiting for reviews label Aug 12, 2016
@blizzzblizzz mentioned this pull request Jun 17, 2022
Merged
R0Wi pushed a commit to R0Wi/server that referenced this pull request Nov 22, 2025
@bigcat88
fix: TaskProcessingAPI - unregister provider endpoint (nextcloud#370)
ef35b71
Found this when writing a small test for **nc_py_api**
without this change `$taskProcessingProvider->id` are always `null` ```php
$taskProcessingProvider = $this->getExAppTaskProcessingProvider($appId, $name);
if ($taskProcessingProvider !== null) {
$this->mapper->delete($taskProcessingProvider);
$this->resetCacheEnabled();
return $taskProcessingProvider;
}
```
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oparozoparoz

Labels

bug

Projects

None yet

Milestone

Nextcloud 9.0.54

Development

Successfully merging this pull request may close these issues.

4 participants

@oparoz@mention-bot@LukasReschke@MariusBluem