Skip to content

Add chunking in SystemTagObjectMapper::getTagIdsForObjects - #37029

Merged
come-nc merged 1 commit into
masterfrom
fix/chunk-objectids-in-systemtagobjectmapper
Mar 13, 2023
Merged

Add chunking in SystemTagObjectMapper::getTagIdsForObjects#37029
come-nc merged 1 commit into
masterfrom
fix/chunk-objectids-in-systemtagobjectmapper

Conversation

@come-nc

@come-nccome-nc commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Summary

This avoids crashing on Oracle with more than 1000 objects

Checklist

@come-nccome-nc added the 3. to review Waiting for reviews label Mar 3, 2023
@come-nccome-nc added this to the Nextcloud 27 milestone Mar 3, 2023
@come-nccome-nc self-assigned this Mar 3, 2023
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to 26

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to 25

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to 24

@come-nc
come-nc requested review from a team, ArtificialOwl, blizzz, icewind1991, nickvergessen and vitormattos and removed request for a teamMarch 3, 2023 09:48
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/rebase

This avoids crashing on Oracle with more than 1000 objects
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command
nextcloud-commandforce-pushed the fix/chunk-objectids-in-systemtagobjectmapper branch from ef9c1f5 to 9b1d779CompareMarch 13, 2023 17:36
@come-nc
come-nc merged commit 7132810 into masterMar 13, 2023
@come-nc
come-nc deleted the fix/chunk-objectids-in-systemtagobjectmapper branch March 13, 2023 21:10
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to 24 failed. Please do this backport manually.

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to 25 failed. Please do this backport manually.

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to 26 failed. Please do this backport manually.

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to 26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to 26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout 26
git pull origin/26
# Create the new backport branch
git checkout -b fix/foo-26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: tags

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export fails in CLI, Never finishes in GUI

3 participants

@come-nc@nickvergessen@vitormattos