Skip to content

Add accessible system tags select - #37065

Merged
Pytal merged 3 commits into
masterfrom
enh/a11y-system-tags
Apr 20, 2023
Merged

Add accessible system tags select#37065
Pytal merged 3 commits into
masterfrom
enh/a11y-system-tags

Conversation

@Pytal

@PytalPytal commented Mar 7, 2023

Copy link
Copy Markdown
Member

Summary

BeforeAfter
imageimage
imageimage
Notes

FIXMEs are out-of-scope

The parseIdFromLocation() util was adapted from

functionparseIdFromLocation(url){
varqueryPos=url.indexOf('?')
if(queryPos>0){
url=url.substr(0,queryPos)
}
varparts=url.split('/')
varresult
do{
result=parts[parts.length-1]
parts.pop()
// note: first result can be empty when there is a trailing slash,
// so we take the part before that
}while(!result&&parts.length>0)
returnresult
}

TODO

Checklist

@blizzz

Copy link
Copy Markdown
Member

master is 27

@Pytal
Pytalforce-pushed the enh/a11y-system-tags branch 2 times, most recently from 36fd841 to d696ea8CompareMarch 16, 2023 17:06
@Pytal
Pytalforce-pushed the enh/a11y-system-tags branch from d696ea8 to d8ea161CompareMarch 31, 2023 01:50
@Pytal
Pytalforce-pushed the enh/a11y-system-tags branch from d8ea161 to a94adf0CompareApril 12, 2023 03:53
@PytalPytal changed the title [WIP] Port system tags selectAdd accessible system tags selectApr 12, 2023
@Pytal

This comment was marked as outdated.

@Pytal
Pytal marked this pull request as ready for review April 12, 2023 04:13
@Pytal
Pytalforce-pushed the enh/a11y-system-tags branch 6 times, most recently from 6018d67 to b3fdc6bCompareApril 14, 2023 21:51
@Pytal
Pytalforce-pushed the enh/a11y-system-tags branch from b3fdc6b to 9f6056aCompareApril 18, 2023 01:34
Pytal added 3 commits April 19, 2023 16:52
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the enh/a11y-system-tags branch from 9f6056a to 177849cCompareApril 19, 2023 23:52
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2023
@Pytal
Pytal merged commit 09cb9c7 into masterApr 20, 2023
@Pytal
Pytal deleted the enh/a11y-system-tags branch April 20, 2023 01:20
pulsejet added a commit that referenced this pull request Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
nextcloud-command pushed a commit that referenced this pull request Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
pulsejet added a commit that referenced this pull request Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
pulsejet added a commit that referenced this pull request Nov 27, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
nextcloud-command pushed a commit that referenced this pull request Nov 27, 2023
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
zak39 pushed a commit to zak39/server that referenced this pull request Dec 19, 2023
With nextcloud#37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
backportbotBot pushed a commit that referenced this pull request Jan 15, 2024
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
[skip ci]
nextcloud-command pushed a commit that referenced this pull request Jul 4, 2024
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
solracsf pushed a commit that referenced this pull request Jul 5, 2024
With #37065, there is no way to hide the tags from the sidebar
by default when they are not relevant or redundant (e.g. the tab
may already show the file's tags). This can be annyoing especially
when the file has many tags. This patch adds an option to hide
the tags from the sidebar by default (the user can still open
the tags tab manually).
This also reduces one request when opening the sidebar when the
tags are turned off, since all tags don't need to be fetched
anymore.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
[skip ci]
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilityenhancementfeature: tags

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal@blizzz@JuliaKirschenheuter@artonge@skjnldsv