Skip to content

add a check for disk_free_space in Config.php - #37070

Merged
szaimen merged 1 commit into
masterfrom
enh/noid/add-free-disk-space-check
Mar 9, 2023
Merged

add a check for disk_free_space in Config.php#37070
szaimen merged 1 commit into
masterfrom
enh/noid/add-free-disk-space-check

Conversation

@szaimen

@szaimenszaimen commented Mar 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@szaimenszaimen added bug 3. to review Waiting for reviews labels Mar 7, 2023
@szaimenszaimen added this to the Nextcloud 27 milestone Mar 7, 2023
@szaimen
szaimen requested review from a team, ArtificialOwl, come-nc and icewind1991 and removed request for a teamMarch 7, 2023 08:51
@szaimen

szaimen commented Mar 7, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@szaimen

szaimen commented Mar 7, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@szaimen

szaimen commented Mar 7, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable24

@szaimenszaimen mentioned this pull request Mar 7, 2023
Merged
4 tasks
@szaimen
szaimen requested a review from solracsfMarch 7, 2023 08:53
@szaimen

szaimen commented Mar 7, 2023

Copy link
Copy Markdown
ContributorAuthor

/rebase

@szaimen
add a check for disk_free_space in Config.php
e87d968
Signed-off-by: Simon L <szaimen@e.mail.de>
@nextcloud-command
nextcloud-commandforce-pushed the enh/noid/add-free-disk-space-check branch from 16582a0 to e87d968CompareMarch 7, 2023 09:43
artonge
artonge approved these changes Mar 9, 2023
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does the disk_free_space function not exist ?

@szaimen

szaimen commented Mar 9, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

When does the disk_free_space function not exist ?

If it is whyever disabled by the admin...

@come-nc

come-nc commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

When does the disk_free_space function not exist ?

If it is whyever disabled by the admin...

You had an actual usecase or is that extra caution?
Because any function can be disabled in php.ini and we cannot test all functions we use.

@szaimen

szaimen commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

You had an actual usecase or is that extra caution?
Because any function can be disabled in php.ini and we cannot test all functions we use.

#37062 (comment)

@szaimen

szaimen commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

CI failure unrelated

@szaimen
szaimen merged commit 694f743 into masterMar 9, 2023
@szaimen
szaimen deleted the enh/noid/add-free-disk-space-check branch March 9, 2023 09:24
@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 9, 2023

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 9, 2023

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 9, 2023

Copy link
Copy Markdown

The backport to stable24 failed. Please do this backport manually.

@szaimen

szaimen commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@szaimen

szaimen commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@szaimen

szaimen commented Mar 9, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable24

This was referenced Mar 9, 2023
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@solracsfsolracsfAwaiting requested review from solracsf

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

3 participants

@szaimen@come-nc@artonge