Skip to content

chore: Address review comments - #37150

Closed
juliusknorr wants to merge 1 commit into
masterfrom
bugfix/cleanup-s3-multipart
Closed

chore: Address review comments#37150
juliusknorr wants to merge 1 commit into
masterfrom
bugfix/cleanup-s3-multipart

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Mar 9, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Addressing review follow ups from #27034

@juliusknorrjuliusknorr added the 2. developing Work in progress label Mar 9, 2023
github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 9, 2023
View reviewed changes
Comment threadlib/private/Files/ObjectStore/ObjectStoreStorage.php Fixed
Comment threadlib/private/Files/ObjectStore/ObjectStoreStorage.php Fixed
Comment threadlib/private/Files/ObjectStore/ObjectStoreStorage.php Fixed
Comment threadapps/dav/lib/Upload/ChunkingV2Plugin.php Fixed
Comment threadapps/dav/lib/Upload/ChunkingV2Plugin.php Outdated

Check notice

Code scanning / Psalm

PossiblyNullArgument

Argument 1 of OCA\DAV\Upload\ChunkingV2Plugin::getUploadStorage cannot be null, possibly null value provided
Comment threadapps/dav/lib/Upload/ChunkingV2Plugin.php Outdated

Check notice

Code scanning / Psalm

PossiblyNullPropertyFetch

Cannot get property on possibly null variable $this->server of type Sabre\DAV\Server|null
Comment threadapps/dav/lib/Upload/ChunkingV2Plugin.php Outdated

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method getNodeForPath on possibly null value
@blizzzblizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@blizzz

blizzz commented Nov 23, 2023

Copy link
Copy Markdown
Member

Please don't forget to set the milestone when opening a PR 😃

@juliusknorr
juliusknorrforce-pushed the bugfix/cleanup-s3-multipart branch from e887c55 to be72b4cCompareJanuary 4, 2024 22:10
github-advanced-security[bot]
github-advanced-securityAI found potential problems Jan 4, 2024
View reviewed changes
Comment threadapps/dav/lib/Upload/ChunkingV2Plugin.php
/** @var ICache */
private $cache;
private ?Server $server = null;
private ?UploadFolder $uploadFolder;

Check notice

Code scanning / Psalm

PropertyNotSetInConstructor

Property OCA\DAV\Upload\ChunkingV2Plugin::$uploadFolder is not defined in constructor of OCA\DAV\Upload\ChunkingV2Plugin or in any private or final methods called in the constructor
This was referenced Mar 12, 2024
Merged
Merged
Merged
@AltahrimAltahrim mentioned this pull request Mar 20, 2024
Merged
@juliusknorr
juliusknorrforce-pushed the bugfix/cleanup-s3-multipart branch from be72b4c to 43098a5CompareJune 25, 2024 16:18
@juliusknorr
chore: Address review comments
b3b567e
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the bugfix/cleanup-s3-multipart branch from 43098a5 to b3b567eCompareJune 25, 2024 16:37
@skjnldsvskjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
@susnux
susnux deleted the bugfix/cleanup-s3-multipart branch April 23, 2025 11:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developingWork in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@blizzz@github-advanced-security@skjnldsv