Uh oh!
There was an error while loading. Please reload this page.
Make it possible to strong type Entity properties - #37209
Closed
come-nc wants to merge 4 commits into
Closed
Conversation
Uh oh!
There was an error while loading. Please reload this page.
come-ncforce-pushed
the
fix/type-entity-properties
branch
from
March 15, 2023 11:25
7127218 to
739f2caComparecome-nc
requested review from
a team, ArtificialOwl, artonge, blizzz and icewind1991
and removed request for
a teamMarch 15, 2023 12:57
This was referenced May 3, 2023
Merged
Closed
Merged
Pytal
reviewed
May 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
Pytal
approved these changes
May 9, 2023
artonge
approved these changes
May 11, 2023
| /** | ||
| * @method int getId() | ||
| * @method ?int getId() |
Check failure
Code scanning / Psalm
ImplementedReturnTypeMismatch
ContributorAuthor
There was a problem hiding this comment.
I do not understand this error, OC\Authentication\Token\PublicKeyToken::getId has a return type of int, not ?int.
come-nc
commented
May 15, 2023
ContributorAuthor
/rebase |
come-ncforce-pushed
the
fix/type-entity-properties
branch
from
May 15, 2023 09:21
4fce81e to
34d2622ComparePropertyNotSetInConstructor still have to be suppressed because properties are actually set in fromRow/fromParams methods, and the init path is too convoluted anyway. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-ncforce-pushed
the
fix/type-entity-properties
branch
from
June 26, 2023 13:58
34d2622 to
f7a61acCompareSigned-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Merged
Merged
Merged
come-nc
commented
Mar 12, 2024
ContributorAuthor
Giving up on this one 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertyNotSetInConstructor still have to be suppressed because properties are
actually set in fromRow/fromParams methods, and the init path is too
convoluted anyway.
Summary
I tried several solutions to improve typing for QBMapper/Entity, I could not find a clean way to type properties without suppressing PropertyNotSetInConstructor manually and adding the @method annotations by hand as well.
But at least we can now type those properties and have psalm-compliant entities.
Also id property is actually nullable and null by default for autoincrement, made that clear in the code.
Checklist